Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include package metadata in `cargo metadata` #5360

Merged
merged 1 commit into from Apr 16, 2018
Merged

Conversation

@euclio
Copy link
Contributor

euclio commented Apr 14, 2018

Fixes #4819.

All-in-all a pretty small change. I'm a little concerned about threading the toml::Value all the way through however, should I make another type? Also, cloning the metadata value initially is maybe not ideal, since it's technically accessible through the original manifest. I figured this way was cleaner.

Fixes #4819.
@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Apr 14, 2018

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Apr 16, 2018

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 16, 2018

📌 Commit 2efeeda has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 16, 2018

⌛️ Testing commit 2efeeda with merge 6cc4780...

bors added a commit that referenced this pull request Apr 16, 2018
include package metadata in `cargo metadata`

Fixes #4819.

All-in-all a pretty small change. I'm a little concerned about threading the `toml::Value` all the way through however, should I make another type? Also, cloning the metadata value initially is maybe not ideal, since it's technically accessible through the original manifest. I figured this way was cleaner.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 16, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6cc4780 to master...

@bors bors merged commit 2efeeda into rust-lang:master Apr 16, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@euclio euclio deleted the euclio:metadata branch Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.