New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: export repository information #6096

Merged
merged 2 commits into from Oct 12, 2018

Conversation

Projects
None yet
6 participants
@mathstuf
Contributor

mathstuf commented Sep 25, 2018

The repository string is made available via the CARGO_PKG_REPOSITORY
environment variable similar to other metadata.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Sep 25, 2018

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive commented Sep 25, 2018

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

build: export repository information
The repository string is made available via the `CARGO_PKG_REPOSITORY`
environment variable similar to other metadata.

@mathstuf mathstuf referenced this pull request Sep 25, 2018

Open

metadata: add repository #45

2 of 2 tasks complete
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Sep 27, 2018

Member

Looks great to me, thanks! Just to confirm with others let's...

@rfcbot fcp merge

Member

alexcrichton commented Sep 27, 2018

Looks great to me, thanks! Just to confirm with others let's...

@rfcbot fcp merge

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Sep 27, 2018

Member

Or perhaps just, @rust-lang/cargo any objections to adding this?

Member

alexcrichton commented Sep 27, 2018

Or perhaps just, @rust-lang/cargo any objections to adding this?

@Eh2406

This comment has been minimized.

Show comment
Hide comment
@Eh2406

Eh2406 Sep 27, 2018

Contributor

Can we clarify in the docs that this is the repository field in your cargo.toml, and that we did not go rummaging around in you git/vc settings to find it. Because, a. we are not that creepy, and b. it may be incorrect.

Contributor

Eh2406 commented Sep 27, 2018

Can we clarify in the docs that this is the repository field in your cargo.toml, and that we did not go rummaging around in you git/vc settings to find it. Because, a. we are not that creepy, and b. it may be incorrect.

@mathstuf

This comment has been minimized.

Show comment
Hide comment
@mathstuf

mathstuf Sep 27, 2018

Contributor

Also updated for homepage and description (though I would assume that cargo build doesn't go looking on Google for my homepage as well ;) ).

Contributor

mathstuf commented Sep 27, 2018

Also updated for homepage and description (though I would assume that cargo build doesn't go looking on Google for my homepage as well ;) ).

@mathstuf

This comment has been minimized.

Show comment
Hide comment
@mathstuf

mathstuf Sep 27, 2018

Contributor

Though cargo coming up with a description for my package could be helpful in some cases ;) .

Contributor

mathstuf commented Sep 27, 2018

Though cargo coming up with a description for my package could be helpful in some cases ;) .

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Sep 27, 2018

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot commented Sep 27, 2018

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Oct 12, 2018

@bors: r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 12, 2018

Contributor

📌 Commit ae6b2f6 has been approved by alexcrichton

Contributor

bors commented Oct 12, 2018

📌 Commit ae6b2f6 has been approved by alexcrichton

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 12, 2018

Contributor

⌛️ Testing commit ae6b2f6 with merge 5fc8ac7...

Contributor

bors commented Oct 12, 2018

⌛️ Testing commit ae6b2f6 with merge 5fc8ac7...

bors added a commit that referenced this pull request Oct 12, 2018

Auto merge of #6096 - mathstuf:export-repository-info, r=alexcrichton
build: export repository information

The repository string is made available via the `CARGO_PKG_REPOSITORY`
environment variable similar to other metadata.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 12, 2018

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5fc8ac7 to master...

Contributor

bors commented Oct 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5fc8ac7 to master...

@bors bors merged commit ae6b2f6 into rust-lang:master Oct 12, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@mathstuf mathstuf deleted the mathstuf:export-repository-info branch Oct 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment