Proptest/Resolver move test helper functions to support #6103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
Could the "cx" => "context" rename be left out? I haven't found historically that it makes reading code all that much easier and it's much nicer (subjectively in my opinion) to use |
|
done |
|
@bors: r+ |
|
📌 Commit 6562123 has been approved by |
|
⌛ Testing commit 6562123 with merge 26962e7cba7975b1a25cac88b7559c32e6d6a474... |
|
💔 Test failed - status-travis |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Sep 27, 2018
Proptest/Resolver move test helper functions to support This moves all the code in `tests/testsuite/resolve.rs` that is not tests of cargo to ` tests/testsuite/support/resolve.rs`. (follow up to #5921) This also clears up some inconsistencies in naming between local variables in `activate_deps_loop` and `BacktrackFrame`. (follow up to #6097) This is a true refactoring, nothing about the executable has changed.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the code in
tests/testsuite/resolve.rsthat is not tests of cargo totests/testsuite/support/resolve.rs. (follow up to #5921)This also clears up some inconsistencies in naming between local variables in
activate_deps_loopandBacktrackFrame. (follow up to #6097) This is a true refactoring, nothing about the executable has changed.