New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second attempt at fixing msys terminal width. #6122

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
4 participants
@ehuss
Contributor

ehuss commented Oct 3, 2018

Lock the max width on msys-based terminals to 60. I tried a lot of different
things, but I was unable to find a way to detect the correct width in mintty.
Unfortunately this means that terminals that work correctly like ConEmu will
also be capped at 60. C'est la vie.

Of course this does not affect cmd, powershell, etc.

Fixes #6108

@rust-highfive

This comment has been minimized.

rust-highfive commented Oct 3, 2018

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

Second attempt at fixing msys terminal width.
Lock the max width on msys-based terminals to 60. I tried a lot of different
things, but I was unable to find a way to detect the correct width in mintty.
Unfortunately this means that terminals that work correctly like ConEmu will
also be capped at 60. C'est la vie.

Of course this does not affect cmd, powershell, etc.
@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Oct 3, 2018

@bors: r+

@bors

This comment has been minimized.

Contributor

bors commented Oct 3, 2018

📌 Commit 0503e34 has been approved by alexcrichton

@bors

This comment has been minimized.

Contributor

bors commented Oct 3, 2018

⌛️ Testing commit 0503e34 with merge cca192a...

bors added a commit that referenced this pull request Oct 3, 2018

Auto merge of #6122 - ehuss:msys-width, r=alexcrichton
Second attempt at fixing msys terminal width.

Lock the max width on msys-based terminals to 60. I tried a lot of different
things, but I was unable to find a way to detect the correct width in mintty.
Unfortunately this means that terminals that work correctly like ConEmu will
also be capped at 60. C'est la vie.

Of course this does not affect cmd, powershell, etc.

Fixes #6108
@bors

This comment has been minimized.

Contributor

bors commented Oct 3, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing cca192a to master...

@bors bors merged commit 0503e34 into rust-lang:master Oct 3, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment