New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proptest basic validation #6149

Merged
merged 2 commits into from Oct 8, 2018

Conversation

Projects
None yet
5 participants
@Eh2406
Contributor

Eh2406 commented Oct 6, 2018

This adds a function for testing that the output of the resolver is basically reasonable. This function has the same signature as the function for running the resolver in a test. So it is easy to switch back and forth, depending on the thoroughness vs speed tradeoff. This also adds a proptest/fuzz that runs this validation against arbitrary registry.

cc #6120
Sorry about the cargo fmt.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Oct 6, 2018

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive commented Oct 6, 2018

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@Eh2406 Eh2406 changed the title from Proptest to proptest basic validation Oct 7, 2018

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Oct 8, 2018

@bors: r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 8, 2018

Contributor

📌 Commit 1719e84 has been approved by alexcrichton

Contributor

bors commented Oct 8, 2018

📌 Commit 1719e84 has been approved by alexcrichton

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 8, 2018

Contributor

⌛️ Testing commit 1719e84 with merge aa06d7c...

Contributor

bors commented Oct 8, 2018

⌛️ Testing commit 1719e84 with merge aa06d7c...

bors added a commit that referenced this pull request Oct 8, 2018

Auto merge of #6149 - Eh2406:proptest, r=alexcrichton
proptest basic validation

This adds a function for testing that the output of the resolver is basically reasonable. This function has the same signature as the function for running the resolver in a test. So it is easy to switch back and forth, depending on the thoroughness vs speed tradeoff. This also adds a proptest/fuzz that runs this validation against arbitrary registry.

cc #6120
Sorry about the cargo fmt.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 8, 2018

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing aa06d7c to master...

Contributor

bors commented Oct 8, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing aa06d7c to master...

@bors bors merged commit 1719e84 into rust-lang:master Oct 8, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@Eh2406 Eh2406 deleted the Eh2406:proptest branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment