New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat "proc-macro" crate type the same as `proc-macro = true` #6256

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@ehuss
Contributor

ehuss commented Nov 3, 2018

Effectively closes #5310 since they are now identical.

@ehuss

This comment has been minimized.

Contributor

ehuss commented Nov 3, 2018

This is a breaking change if you say:

crate-type = ["proc-macro"]
plugin = true

Found this in the https://crates.io/crates/arthas_derive package. Do you think it is worth detecting this scenario and allowing it with a warning?

@ehuss ehuss force-pushed the ehuss:proc-macro-crate-type branch from 5b8301c to f867f45 Nov 3, 2018

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Nov 5, 2018

Nice catch on that regression, yeah let's emit a warning for now for that. Additionally, could a warning be printed to say that proc-macro = true is favored over crate-type = ["..."]?

@ehuss ehuss force-pushed the ehuss:proc-macro-crate-type branch from f867f45 to b0e767f Nov 6, 2018

@ehuss

This comment has been minimized.

Contributor

ehuss commented Nov 6, 2018

Added some warnings. I also added a check for multiple crate-types, just to assert an assumption, but maybe that's not necessary (rustc has the same check).

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Nov 6, 2018

@bors: r+

@bors

This comment has been minimized.

Contributor

bors commented Nov 6, 2018

📌 Commit b0e767f has been approved by alexcrichton

@bors

This comment has been minimized.

Contributor

bors commented Nov 6, 2018

⌛️ Testing commit b0e767f with merge 787bee6...

bors added a commit that referenced this pull request Nov 6, 2018

Auto merge of #6256 - ehuss:proc-macro-crate-type, r=alexcrichton
Treat "proc-macro" crate type the same as `proc-macro = true`

Effectively closes #5310 since they are now identical.
@bors

This comment has been minimized.

Contributor

bors commented Nov 6, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 787bee6 to master...

@bors bors merged commit b0e767f into rust-lang:master Nov 6, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment