New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small things to help with fuzz tests #6274

Merged
merged 5 commits into from Nov 7, 2018

Conversation

Projects
None yet
6 participants
@Eh2406
Contributor

Eh2406 commented Nov 7, 2018

These are some small fixes to make it less likely to have randomly failing tests. This also documents what to do, and not to feel guilty, if the test do fail.

@rust-highfive

This comment has been minimized.

rust-highfive commented Nov 7, 2018

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@Eh2406

This comment has been minimized.

Contributor

Eh2406 commented Nov 7, 2018

@ehuss Do you think it is ok to call out pinging #6258?
@matthiaskrgr Do you think these comments would have made your experience easier?

@ehuss

This comment has been minimized.

Contributor

ehuss commented Nov 7, 2018

@ehuss Do you think it is ok to call out pinging #6258?

Seems fine to me.

@matthiaskrgr

This comment has been minimized.

Contributor

matthiaskrgr commented Nov 7, 2018

Looks good to me, thanks! :)

@Eh2406 Eh2406 force-pushed the Eh2406:small_things branch from 49a7b0a to 8cfa1dd Nov 7, 2018

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Nov 7, 2018

@bors: r+

@bors

This comment has been minimized.

Contributor

bors commented Nov 7, 2018

📌 Commit 7ca46cc has been approved by alexcrichton

@bors

This comment has been minimized.

Contributor

bors commented Nov 7, 2018

⌛️ Testing commit 7ca46cc with merge 077087a...

bors added a commit that referenced this pull request Nov 7, 2018

Auto merge of #6274 - Eh2406:small_things, r=alexcrichton
Small things to help with fuzz tests

These are some small fixes to make it less likely to have randomly failing tests. This also documents what to do, and not to feel guilty, if the test do fail.
@bors

This comment has been minimized.

Contributor

bors commented Nov 7, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 077087a to master...

@bors bors merged commit 7ca46cc into rust-lang:master Nov 7, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@Eh2406 Eh2406 deleted the Eh2406:small_things branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment