New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid retaining all rustc output in memory. #6289

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
4 participants
@ehuss
Contributor

ehuss commented Nov 9, 2018

There are still a few cases where all output is buffered. They are:

  • Running discovery commands like rustc -vV, rustc --print xxx, etc.
  • Build script output.
  • Testsuite's debug .stream() function.

This should cover the concern of the issue, though, which is normal compilation.

Closes #6197

@rust-highfive

This comment has been minimized.

rust-highfive commented Nov 9, 2018

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented Nov 9, 2018

@bors: r+

@bors

This comment has been minimized.

Contributor

bors commented Nov 9, 2018

📌 Commit 17b6df9 has been approved by alexcrichton

@bors

This comment has been minimized.

Contributor

bors commented Nov 9, 2018

⌛️ Testing commit 17b6df9 with merge eeb3e16...

bors added a commit that referenced this pull request Nov 9, 2018

Auto merge of #6289 - ehuss:no-buffer-output, r=alexcrichton
Avoid retaining all rustc output in memory.

There are still a few cases where all output is buffered. They are:
- Running discovery commands like `rustc -vV`, `rustc --print xxx`, etc.
- Build script output.
- Testsuite's debug `.stream()` function.

This should cover the concern of the issue, though, which is normal compilation.

Closes #6197
@bors

This comment has been minimized.

Contributor

bors commented Nov 9, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing eeb3e16 to master...

@bors bors merged commit 17b6df9 into rust-lang:master Nov 9, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment