Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement generate-index-metadata command #6324
Conversation
rust-highfive
assigned
alexcrichton
Nov 17, 2018
This comment has been minimized.
This comment has been minimized.
rust-highfive
commented
Nov 17, 2018
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR! Unfortunately now though there's a soft feature freeze in Cargo so it may be some time before the cargo team has bandwidth to review this |
synek317
changed the title
Synek317 generate index metadata
Implement generate-index-metadata command
Nov 19, 2018
This comment has been minimized.
This comment has been minimized.
|
As someone without much of the background context, I would like to see more documentation. What dose it do? How can it be used? How can it be configured? If my guess about what this does, I'd love to see an extenuation that let us take a resolution bug report and tern it into a reproducible test case. |
This comment has been minimized.
This comment has been minimized.
|
|
synek317
force-pushed the
synek317:synek317_generate_index_metadata
branch
from
95795ee
to
2a5ad7c
Dec 19, 2018
added some commits
Nov 17, 2018
synek317
force-pushed the
synek317:synek317_generate_index_metadata
branch
from
2a5ad7c
to
440939e
Dec 19, 2018
This comment has been minimized.
This comment has been minimized.
synek317
commented
Dec 21, 2018
|
@alexcrichton was it freeze until rust 2018 release or is it freeze to the end of the year? |
This comment has been minimized.
This comment has been minimized.
|
cc @ehuss |
This comment has been minimized.
This comment has been minimized.
|
At this time I think we'd like to experiment with index-related commands out of tree. I'm putting together a new subcommand which provides several options for managing an index, which I'll be posting soon. Do you have interest in running a registry? If so, feedback and testing would be helpful to figure out what features are needed. |
This comment has been minimized.
This comment has been minimized.
synek317
commented
Dec 27, 2018
•
|
This is my subcommand to create registry in a git repository: https://github.com/synek317/cargo-git-registry It is very much work in progress but with With |
This comment has been minimized.
This comment has been minimized.
|
@synek317 Nice! I'm trying to make it possible to implement this separately just using |
This comment has been minimized.
This comment has been minimized.
|
Closing in favour of the conversation in #4497 and the out-of-tree experimentation in https://github.com/ehuss/cargo-index. |
synek317 commentedNov 17, 2018
It solves the issue #4497