New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message when resolving dependencies #6510

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
5 participants
@d-e-s-o
Copy link
Contributor

d-e-s-o commented Jan 2, 2019

The error message:

Attempting to resolve a with more then one crate with the links=

seems to be missing a noun. It appears that we are resolving a
dependency, so adding that.

Fix error message when resolving dependencies
The error message:
> Attempting to resolve a with more then one crate with the links=

seems to be missing a noun. It appears that we are resolving a
dependency, so adding that.
@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Jan 2, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dwijnand (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@dwijnand

This comment has been minimized.

Copy link
Member

dwijnand commented Jan 2, 2019

Good spot, thanks!

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2019

📌 Commit bd536c6 has been approved by dwijnand

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2019

⌛️ Testing commit bd536c6 with merge 8f6743b...

bors added a commit that referenced this pull request Jan 2, 2019

Auto merge of #6510 - d-e-s-o:add-missing-noun, r=dwijnand
Fix error message when resolving dependencies

The error message:
> Attempting to resolve a with more then one crate with the links=

seems to be missing a noun. It appears that we are resolving a
dependency, so adding that.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2019

💔 Test failed - status-appveyor

@dwijnand

This comment has been minimized.

Copy link
Member

dwijnand commented Jan 2, 2019

Hmm

error[E0407]: method `name` is not a member of trait `failure::Fail`
  --> C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\opener-0.3.2\src\lib.rs:40:17
   |
40 | #[derive(Debug, Fail)]
   |                 ^^^^ not a member of trait `failure::Fail`
@dwijnand

This comment has been minimized.

Copy link
Member

dwijnand commented Jan 2, 2019

Hmm, this looks like a crate version coherence problem.

rust-lang-nursery/failure#289 introduced fn name(&self) -> Option<&str> on the Fail trait which was cut as failure 0.1.5, but from the build log we depend on different versions of failure and failure_derive:

   Compiling failure_derive v0.1.5
   ...
   Compiling failure v0.1.4
@dwijnand

This comment has been minimized.

Copy link
Member

dwijnand commented Jan 2, 2019

The equivalent nightly build on Travis CI happily picks failure_derive v0.1.4: https://travis-ci.org/rust-lang/cargo/jobs/474305951. I'm not sure why there's a difference there either.

I'm not sure how to solve the issue, but it's obviously not caused by this PR.

@Eh2406

This comment has been minimized.

Copy link
Contributor

Eh2406 commented Jan 2, 2019

The easiest way to test if this is transient is:
@bors: retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2019

⌛️ Testing commit bd536c6 with merge 3c65c40...

bors added a commit that referenced this pull request Jan 2, 2019

Auto merge of #6510 - d-e-s-o:add-missing-noun, r=dwijnand
Fix error message when resolving dependencies

The error message:
> Attempting to resolve a with more then one crate with the links=

seems to be missing a noun. It appears that we are resolving a
dependency, so adding that.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: dwijnand
Pushing 3c65c40 to master...

@bors bors merged commit bd536c6 into rust-lang:master Jan 2, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@dwijnand

This comment has been minimized.

Copy link
Member

dwijnand commented Jan 2, 2019

Well, I knew from other PRs landing that it didn't always come up.

But I think that makes it worst, no? Why is sometimes failure_derive v0.1.5 picked and sometimes failure_derive v0.1.4??

@Eh2406

This comment has been minimized.

Copy link
Contributor

Eh2406 commented Jan 2, 2019

my best guess is... maybe this build happened during the time when failure_derive v0.1.5 was published but failure v0.1.5 had not yet bean.

@dwijnand

This comment has been minimized.

Copy link
Member

dwijnand commented Jan 2, 2019

Yep, good thinking, same time: rust-lang/crates.io-index@36621e0

@ehuss ehuss referenced this pull request Jan 3, 2019

Merged

Update cargo #57315

bors added a commit to rust-lang/rust that referenced this pull request Jan 4, 2019

Auto merge of #57315 - ehuss:update-cargo, r=alexcrichton
Update cargo

24 commits in 0d1f1bbeabd5b43a7f3ecfa16540af8e76d5efb4..34320d212dca8cd27d06ce93c16c6151f46fcf2e
2018-12-19 14:45:14 +0000 to 2019-01-03 19:12:38 +0000
- Display environment variables for rustc commands (rust-lang/cargo#6492)
- Fix a very minor race condition in `cargo fix`. (rust-lang/cargo#6515)
- Add a high-level overview of how `fix` works. (rust-lang/cargo#6516)
- Add dependency `registry` to `cargo metadata`. (rust-lang/cargo#6500)
- Fix fingerprint calculation for patched deps. (rust-lang/cargo#6493)
- serialize version directly (rust-lang/cargo#6512)
- use DYLD_FALLBACK_LIBRARY_PATH for dylib_path_envvar on macOS (rust-lang/cargo#6355)
- Fix error message when resolving dependencies (rust-lang/cargo#6510)
- use PathBuf in cargo metadata (rust-lang/cargo#6511)
- Fixed link to testsuite in CONTRIBUTING.md (rust-lang/cargo#6506)
- Update display of contents of Cargo.toml (rust-lang/cargo#6501)
- Update display of contents of Cargo.toml (rust-lang/cargo#6502)
- Fixup cargo install's help message (rust-lang/cargo#6495)
- testsuite: Require failing commands to check output. (rust-lang/cargo#6497)
- Delete unnecessary 'return' (rust-lang/cargo#6496)
- Fix new unused patch warning. (rust-lang/cargo#6494)
- Some minor documentation changes. (rust-lang/cargo#6481)
- Add `links` to `cargo metadata`. (rust-lang/cargo#6480)
- Salvaged semver work (rust-lang/cargo#6476)
- Warn on unused patches. (rust-lang/cargo#6470)
- don't write a an incorrect rustc version to the fingerprint file (rust-lang/cargo#6473)
- Rewrite `login` and registry cleanups. (rust-lang/cargo#6466)
- [issue#6461] Fix cargo commands list (rust-lang/cargo#6462)
- Restrict registry names to same style as package names. (rust-lang/cargo#6469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment