New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for bad manifest with `cargo install`. #6560

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
5 participants
@ehuss
Copy link
Contributor

ehuss commented Jan 17, 2019

The old code assumed that any error loading a manifest meant that the
manifest didn't exist, but there are many other reasons it may fail.
Add a few helpful messages for some common cases.

First noticed at #5654 (comment)

Better error message for bad manifest with `cargo install`.
The old code assumed that any error loading a manifest meant that the
manifest didn't exist, but there are many other reasons it may fail.
Add a few helpful messages for some common cases.
@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Jan 17, 2019

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@Eh2406

This comment has been minimized.

Copy link
Contributor

Eh2406 commented Jan 17, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 17, 2019

📌 Commit 3378a5a has been approved by Eh2406

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 17, 2019

⌛️ Testing commit 3378a5a with merge fabe552...

bors added a commit that referenced this pull request Jan 17, 2019

Auto merge of #6560 - ehuss:better-install-error, r=Eh2406
Better error message for bad manifest with `cargo install`.

The old code assumed that any error loading a manifest meant that the
manifest didn't exist, but there are many other reasons it may fail.
Add a few helpful messages for some common cases.

First noticed at #5654 (comment)
@dwijnand

This comment has been minimized.

Copy link
Member

dwijnand commented Jan 17, 2019

Thanks, @ehuss. I think I implemented that, not sure why like that, though.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 17, 2019

💥 Test timed out

@dwijnand

This comment has been minimized.

Copy link
Member

dwijnand commented Jan 17, 2019

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 17, 2019

⌛️ Testing commit 3378a5a with merge ffe6587...

bors added a commit that referenced this pull request Jan 17, 2019

Auto merge of #6560 - ehuss:better-install-error, r=Eh2406
Better error message for bad manifest with `cargo install`.

The old code assumed that any error loading a manifest meant that the
manifest didn't exist, but there are many other reasons it may fail.
Add a few helpful messages for some common cases.

First noticed at #5654 (comment)
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 18, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Eh2406
Pushing ffe6587 to master...

@bors bors merged commit 3378a5a into rust-lang:master Jan 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@ehuss ehuss referenced this pull request Jan 18, 2019

Merged

Update cargo #57721

bors added a commit to rust-lang/rust that referenced this pull request Jan 19, 2019

Auto merge of #57721 - ehuss:update-cargo, r=alexcrichton
Update cargo

Unblocks #56884  cc @euclio

6 commits in 2b4a5f1f0bb6e13759e88ea9512527b0beba154f..ffe65875fd05018599ad07e7389e99050c7915be
2019-01-12 04:13:12 +0000 to 2019-01-17 23:57:50 +0000
- Better error message for bad manifest with `cargo install`. (rust-lang/cargo#6560)
- relax rustdoc output assertion (rust-lang/cargo#6559)
- touch some files when we use them (rust-lang/cargo#6477)
- Add documentation for new package/publish feature flags. (rust-lang/cargo#6553)
- Update chat link to Discord. (rust-lang/cargo#6554)
- Fix typo (rust-lang/cargo#6552)

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment