New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlapping progress with stdout. #6618

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Projects
None yet
4 participants
@ehuss
Copy link
Contributor

ehuss commented Feb 2, 2019

Minor issue introduced in #6615. The progress bar was not being cleared for stdout output (because Shell only does stderr).

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Feb 2, 2019

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@Eh2406

This comment has been minimized.

Copy link
Contributor

Eh2406 commented Feb 2, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 2, 2019

📌 Commit 00b4efe has been approved by Eh2406

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 2, 2019

⌛️ Testing commit 00b4efe with merge 4e74e2f...

bors added a commit that referenced this pull request Feb 2, 2019

Auto merge of #6618 - ehuss:fix-progress-stdout, r=Eh2406
Fix overlapping progress with stdout.

Minor issue introduced in #6615. The progress bar was not being cleared for stdout output (because Shell only does stderr).
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 2, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Eh2406
Pushing 4e74e2f to master...

@bors bors merged commit 00b4efe into rust-lang:master Feb 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@ehuss ehuss referenced this pull request Feb 3, 2019

Merged

Update cargo #58131

bors added a commit to rust-lang/rust that referenced this pull request Feb 5, 2019

Auto merge of #58131 - ehuss:update-cargo, r=alexcrichton
Update cargo

7 commits in 245818076052dd7178f5bb7585f5aec5b6c1e03e..4e74e2fc0908524d17735c768067117d3e84ee9c
2019-01-27 15:17:26 +0000 to 2019-02-02 17:48:44 +0000
- Fix overlapping progress with stdout. (rust-lang/cargo#6618)
- Improve progress bar flickering. (rust-lang/cargo#6615)
- Add detail to multiple rename deps (rust-lang/cargo#6603)
- Fix race condition in local registry crate unpacking (rust-lang/cargo#6591)
- Revert "Make incremental compilation the default for all profiles." (rust-lang/cargo#6610)
- Fixup the docs on crate-type (rust-lang/cargo#6606)
- Document that owner --add now just invites (rust-lang/cargo#6604)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment