Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bail when trying to run "test --doc --no-run" #6628

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
4 participants
@dwijnand
Copy link
Member

dwijnand commented Feb 4, 2019

Fixes #5242

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Feb 4, 2019

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@Eh2406

This comment has been minimized.

Copy link
Contributor

Eh2406 commented Feb 4, 2019

Should this have a test?

@dwijnand

This comment has been minimized.

Copy link
Member Author

dwijnand commented Feb 4, 2019

Such a stickler for the rules... 😉

I'll have a doc test no run test running in no time.

@dwijnand dwijnand force-pushed the dwijnand:doc-no-run branch from d3ccda7 to fabda17 Feb 4, 2019

@Eh2406

This comment has been minimized.

Copy link
Contributor

Eh2406 commented Feb 4, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 4, 2019

📌 Commit fabda17 has been approved by Eh2406

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 4, 2019

⌛️ Testing commit fabda17 with merge f7ba714...

bors added a commit that referenced this pull request Feb 4, 2019

Auto merge of #6628 - dwijnand:doc-no-run, r=Eh2406
Bail when trying to run "test --doc --no-run"

Fixes #5242
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 4, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Eh2406
Pushing f7ba714 to master...

@bors bors merged commit fabda17 into rust-lang:master Feb 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@dwijnand dwijnand deleted the dwijnand:doc-no-run branch Feb 4, 2019

bors added a commit to rust-lang/rust that referenced this pull request Feb 10, 2019

Auto merge of #58358 - pietroalbini:update-cargo, r=Mark-Simulacrum
Bump cargo to 865cb70

Merged PRs:

* Replace util::without_prefix with Path::strip_prefix rust-lang/cargo#6620
* keep track of crates that are whitelisted to be used even if yanked rust-lang/cargo#6611
* Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. rust-lang/cargo#6625
* Bail when trying to run "test --doc --no-run" rust-lang/cargo#6628
* In cargo test's help, add that examples are built rust-lang/cargo#6619
* Extract & re-use filter_targets in cargo_compile rust-lang/cargo#6621
* Test cleanup: remove unnecessary with_status(0) rust-lang/cargo#6630
* Fix run's help message rust-lang/cargo#6631
* Some updates to bash completion. rust-lang/cargo#6644
* Introduce Source::download_now rust-lang/cargo#6637
* Switch from unused_imports to deprecated to test unfixable warnings rust-lang/cargo#6649

bors added a commit to rust-lang/rust that referenced this pull request Feb 11, 2019

Auto merge of #58358 - pietroalbini:update-cargo, r=Mark-Simulacrum
Bump cargo to 865cb70

Merged PRs:

* Replace util::without_prefix with Path::strip_prefix rust-lang/cargo#6620
* keep track of crates that are whitelisted to be used even if yanked rust-lang/cargo#6611
* Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. rust-lang/cargo#6625
* Bail when trying to run "test --doc --no-run" rust-lang/cargo#6628
* In cargo test's help, add that examples are built rust-lang/cargo#6619
* Extract & re-use filter_targets in cargo_compile rust-lang/cargo#6621
* Test cleanup: remove unnecessary with_status(0) rust-lang/cargo#6630
* Fix run's help message rust-lang/cargo#6631
* Some updates to bash completion. rust-lang/cargo#6644
* Introduce Source::download_now rust-lang/cargo#6637
* Switch from unused_imports to deprecated to test unfixable warnings rust-lang/cargo#6649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.