Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Stricter package change detection. #6740
This changes it so that when
This also changes it so that it checks all files in the package file. Previously it skipped files based on search rules such as the
#6717 is caused by
This change addresses it by no longer checking mtimes, but instead file contents.
Some alternate solutions are:
I don't feel strongly about any option. Any preference? I'm fine with doing alternate PRs.
Oh ok I think I see what's happening now, I originally though that this was all related to
In general we want to more to a more content-based mtime solution but have been hesitant to do so due to performance concerns, but this is not on a performance critical path because it's only done during packaging.
In light of all that I'm personally in favor of the solution proposed here! While agreed that there's always a risk of unintended breakage this looks simple enough that I think we can deal with any breakage as it comes up