Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolving yanked crates when using a local registry. #6742

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
6 participants
@hugwijst
Copy link
Contributor

hugwijst commented Mar 13, 2019

Fixes #6741.

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Mar 13, 2019

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@hugwijst

This comment has been minimized.

Copy link
Contributor Author

hugwijst commented Mar 13, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 13, 2019

@hugwijst: 🔑 Insufficient privileges: not in try users

@hugwijst

This comment has been minimized.

Copy link
Contributor Author

hugwijst commented Mar 13, 2019

Test failure in nightly reported on #6258.

@dwijnand

This comment has been minimized.

Copy link
Member

dwijnand commented Mar 13, 2019

Restarted the Travis job that failed.

@Eh2406

This comment has been minimized.

Copy link
Contributor

Eh2406 commented Mar 13, 2019

LGTM

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Mar 13, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 13, 2019

📌 Commit 915b49d has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 13, 2019

⌛️ Testing commit 915b49d with merge 8ebf915...

bors added a commit that referenced this pull request Mar 13, 2019

Auto merge of #6742 - hugwijst:yanked_local_registry_bug, r=alexcrichton
Fix resolving yanked crates when using a local registry.

Fixes #6741.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 13, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 8ebf915 to master...

@bors bors merged commit 915b49d into rust-lang:master Mar 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@hugwijst hugwijst deleted the hugwijst:yanked_local_registry_bug branch Mar 13, 2019

@hugwijst

This comment has been minimized.

Copy link
Contributor Author

hugwijst commented Mar 13, 2019

Can we backport this into beta? Getting a 1.33.1 is probably a long shot.

We'll need to skip 1.33.0 internally, as having commits that cannot be successfully build anymore due to an update to the local registry is unacceptable.

@Eh2406

This comment has been minimized.

Copy link
Contributor

Eh2406 commented Mar 13, 2019

The thing it is fixing got a backport #6655 so I am +1 on a backport.

bors added a commit that referenced this pull request Mar 15, 2019

Auto merge of #6750 - hugwijst:yanked_local_registry_bug_backport, r=…
…ehuss

[backport] Fix resolving yanked crates when using a local registry.

This is a backport #6742 to fix #6741.

@ehuss ehuss referenced this pull request Mar 29, 2019

Merged

Update cargo #59516

bors added a commit to rust-lang/rust that referenced this pull request Mar 30, 2019

Auto merge of #59516 - ehuss:update-cargo, r=alexcrichton
Update cargo

Update cargo

22 commits in 0e35bd8af0ec72d3225c4819b330b94628f0e9d0..63231f438a2b5b84ccf319a5de22343ee0316323
2019-03-13 06:52:51 +0000 to 2019-03-27 12:26:45 +0000
- Code cleanup (rust-lang/cargo#6787)
- Add cargo:rustc-link-arg to pass custom linker arguments (rust-lang/cargo#6298)
- Testsuite: remove some unnecessary is_nightly checks. (rust-lang/cargo#6786)
- cargo metadata: Don't show `null` deps. (rust-lang/cargo#6534)
- Some fingerprint cleanup. (rust-lang/cargo#6785)
- Fix fingerprint for canceled build script. (rust-lang/cargo#6782)
- Canonicalize default target if it ends with `.json` (rust-lang/cargo#6778)
- Fix setting `panic=unwind` compiling lib a extra time. (rust-lang/cargo#6781)
- Always nicely show errors from crates.io if possible (rust-lang/cargo#6771)
- Testsuite: Make `cwd()` relative to project root. (rust-lang/cargo#6768)
- Allow `cargo fix` if gitignore matches root working dir. (rust-lang/cargo#6767)
- Remove redundant imports (rust-lang/cargo#6763)
- Handle backcompat hazard with `toml` crate (rust-lang/cargo#6761)
- Fix spurious error in dirty_both_lib_and_test. (rust-lang/cargo#6756)
- Update toml requirement from 0.4.2 to 0.5.0 (rust-lang/cargo#6760)
- Reuse std::env::consts::EXE_SUFFIX (rust-lang/cargo#6758)
- Proptest 0.9.1 (rust-lang/cargo#6753)
- Don't need extern crate in 2018 (rust-lang/cargo#6752)
- Release a jobserver token while locking a file (rust-lang/cargo#6748)
- Minor doc fix for publish command synopsis (rust-lang/cargo#6749)
- Stricter package change detection. (rust-lang/cargo#6740)
- Fix resolving yanked crates when using a local registry. (rust-lang/cargo#6742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.