Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink dSYM on macOS example binaries. #6891

Merged
merged 1 commit into from Apr 30, 2019

Conversation

Projects
None yet
4 participants
@ehuss
Copy link
Contributor

commented Apr 29, 2019

Examples previously ended up with a layout such as:

target/debug/examples/ex1
target/debug/examples/ex1.d
target/debug/examples/ex1-966e505ad4696130
target/debug/examples/ex1-966e505ad4696130.d
target/debug/examples/ex1-966e505ad4696130.dSYM/…

If you attempt to run lldb on the executable without the hash (target/debug/examples/ex1), then symbols could not be found. This PR solves this by creating a symlink from ex1.dSYM -> ex1-966e505ad4696130.dSYM.

Closes #6889

@rust-highfive

This comment has been minimized.

Copy link

commented Apr 29, 2019

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

📌 Commit f95f55a has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

⌛️ Testing commit f95f55a with merge af1fcb3...

bors added a commit that referenced this pull request Apr 30, 2019

Auto merge of #6891 - ehuss:uplift-mac-dsym-example, r=alexcrichton
Symlink dSYM on macOS example binaries.

Examples previously ended up with a layout such as:

```
target/debug/examples/ex1
target/debug/examples/ex1.d
target/debug/examples/ex1-966e505ad4696130
target/debug/examples/ex1-966e505ad4696130.d
target/debug/examples/ex1-966e505ad4696130.dSYM/…
```

If you attempt to run lldb on the executable without the hash (`target/debug/examples/ex1`), then symbols could not be found. This PR solves this by creating a symlink from `ex1.dSYM -> ex1-966e505ad4696130.dSYM`.

Closes #6889
@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing af1fcb3 to master...

@bors bors merged commit f95f55a into rust-lang:master Apr 30, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.