Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple --features options #7084

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@scruffystuffs
Copy link

commented Jul 1, 2019

Closes #7076

Pretty straightforward, but I added an extra test to make sure that space-separated features work in conjunction with multiple --features options.

@rust-highfive

This comment has been minimized.

Copy link

commented Jul 1, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@scruffystuffs scruffystuffs force-pushed the scruffystuffs:invoke-feature-multi branch from ac72a80 to 51c26b6 Jul 1, 2019

@scruffystuffs

This comment has been minimized.

Copy link
Author

commented Jul 1, 2019

Fixed the fmt error on the test file.

@alexcrichton alexcrichton added the T-cargo label Jul 8, 2019

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

@rfcbot fcp merge

I know I've been bitten by this before and this seems reasonable to me! Since this would be a change to stable behavior though (an enhancement really) I'd like to query the team as well.

@rfcbot

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.