Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force clippy to run. #7157

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@ehuss
Copy link
Contributor

commented Jul 20, 2019

This causes cargo clippy-preview to always run, instead of possibly emitting no output if it is run a second time.

This is just a personal preference of mine, but I think would be better behavior which we have talked about before. I don't think the arguments that it should be "fast" like cargo check apply here. Once cache-messages is stabilized, this can be removed.

@rust-highfive

This comment has been minimized.

Copy link

commented Jul 20, 2019

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@ehuss

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

cc @yaahallo @Manishearth . WDYT?

@Eh2406

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

LGTM

@Manishearth

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Yeah, this is definitely the behavior we want; perhaps with a flag or something to get the old behavior back. One of the reasons for switching to cargo for this was that such choices become easier.

@yaahc

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

👍

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

📌 Commit 1c6d8bb has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

⌛️ Testing commit 1c6d8bb with merge e4f4975...

bors added a commit that referenced this pull request Jul 23, 2019

Auto merge of #7157 - ehuss:force-clippy, r=alexcrichton
Force clippy to run.

This causes `cargo clippy-preview` to always run, instead of possibly emitting no output if it is run a second time.

This is just a personal preference of mine, but I think would be better behavior which we have talked about before.  I don't think the arguments that it should be "fast" like `cargo check` apply here.  Once [cache-messages](#6986) is stabilized, this can be removed.
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

💔 Test failed - checks-travis

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

@bors: retry

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

⌛️ Testing commit 1c6d8bb with merge c8fad5b...

bors added a commit that referenced this pull request Jul 23, 2019

Auto merge of #7157 - ehuss:force-clippy, r=alexcrichton
Force clippy to run.

This causes `cargo clippy-preview` to always run, instead of possibly emitting no output if it is run a second time.

This is just a personal preference of mine, but I think would be better behavior which we have talked about before.  I don't think the arguments that it should be "fast" like `cargo check` apply here.  Once [cache-messages](#6986) is stabilized, this can be removed.
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing c8fad5b to master...

@bors bors merged commit 1c6d8bb into rust-lang:master Jul 23, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

bors added a commit to rust-lang/rust that referenced this pull request Jul 25, 2019

Auto merge of #62914 - ehuss:update-cargo, r=alexcrichton
Update cargo

11 commits in e3563dbdcd2e370bc4f11d080f739d82d25773fd..d0f828419d6ce6be21a90866964f58eb2c07cd56
2019-07-16 19:22:44 +0000 to 2019-07-23 21:58:59 +0000
- Remove include/exclude glob warning. (rust-lang/cargo#7170)
- Optimize lock file format for git merge conflicts (rust-lang/cargo#7070)
- Set up CI with Azure Pipelines (rust-lang/cargo#7139)
- Force clippy to run. (rust-lang/cargo#7157)
- Work around #61440 (rust-lang/cargo#7158)
- initial working version of cargo fix --clippy (rust-lang/cargo#7069)
- Optimize runtime of `#[cargo_test_macro]` (rust-lang/cargo#7146)
- Don't fail if we can't acquire readonly lock (rust-lang/cargo#7149)
- Add support for multiple --features options (rust-lang/cargo#7084)
- Fix a typo in an env var name (rust-lang/cargo#7145)
- Add a way to disable all nightly tests (rust-lang/cargo#7142)

bors added a commit to rust-lang/rust that referenced this pull request Jul 26, 2019

Auto merge of #62914 - ehuss:update-cargo, r=alexcrichton
Update cargo

11 commits in e3563dbdcd2e370bc4f11d080f739d82d25773fd..d0f828419d6ce6be21a90866964f58eb2c07cd56
2019-07-16 19:22:44 +0000 to 2019-07-23 21:58:59 +0000
- Remove include/exclude glob warning. (rust-lang/cargo#7170)
- Optimize lock file format for git merge conflicts (rust-lang/cargo#7070)
- Set up CI with Azure Pipelines (rust-lang/cargo#7139)
- Force clippy to run. (rust-lang/cargo#7157)
- Work around #61440 (rust-lang/cargo#7158)
- initial working version of cargo fix --clippy (rust-lang/cargo#7069)
- Optimize runtime of `#[cargo_test_macro]` (rust-lang/cargo#7146)
- Don't fail if we can't acquire readonly lock (rust-lang/cargo#7149)
- Add support for multiple --features options (rust-lang/cargo#7084)
- Fix a typo in an env var name (rust-lang/cargo#7145)
- Add a way to disable all nightly tests (rust-lang/cargo#7142)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.