Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message for unmatched prerelease dependencies #7191

Merged
merged 2 commits into from Aug 1, 2019

Conversation

@debris
Copy link
Contributor

commented Jul 30, 2019

fixes #7007

error message before:

error: no matching package named `a` found
location searched: [..]
perhaps you meant: a
required by package `b v0.1.0 ([..])`

error message now

error: no matching package named `a` found
location searched: [..]
prerelease package needs to be specified explicitly
a = { version = "0.1.1-alpha.0" }
required by package `b v0.1.0 ([..])`
@Eh2406

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

@debris thanks for the PR!
needs a cargo fmt but lgtm. @alexcrichton thoughts?

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Seems reasonable to me! Any and all improvements to error messages always sounds good to me :)

@ehuss

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

The nightly errors on CI should now be fixed.

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@bors: r=Eh2406

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

📌 Commit 577968e has been approved by Eh2406

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

⌛️ Testing commit 577968e with merge 85b9566...

bors added a commit that referenced this pull request Aug 1, 2019

Auto merge of #7191 - debris:prerelease_error_message, r=Eh2406
improve error message for unmatched prerelease dependencies

fixes #7007

error message before:

```
error: no matching package named `a` found
location searched: [..]
perhaps you meant: a
required by package `b v0.1.0 ([..])`
```

error message now

```
error: no matching package named `a` found
location searched: [..]
prerelease package needs to be specified explicitly
a = { version = "0.1.1-alpha.0" }
required by package `b v0.1.0 ([..])`
```
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

☀️ Test successful - checks-azure
Approved by: Eh2406
Pushing 85b9566 to master...

@bors bors merged commit 577968e into rust-lang:master Aug 1, 2019

8 of 10 checks passed

rust-lang.cargo Build #20190731.1 failed
Details
rust-lang.cargo (Linux nightly) Linux nightly failed
Details
homu Test successful
Details
rust-lang.cargo (Linux beta) Linux beta succeeded
Details
rust-lang.cargo (Linux stable) Linux stable succeeded
Details
rust-lang.cargo (Windows x86_64-msvc) Windows x86_64-msvc succeeded
Details
rust-lang.cargo (docs) docs succeeded
Details
rust-lang.cargo (macOS) macOS succeeded
Details
rust-lang.cargo (resolver) resolver succeeded
Details
rust-lang.cargo (rustfmt) rustfmt succeeded
Details
@bors bors referenced this pull request Aug 1, 2019

@debris debris deleted the debris:prerelease_error_message branch Aug 6, 2019

@ehuss ehuss referenced this pull request Aug 8, 2019

bors added a commit to rust-lang/rust that referenced this pull request Aug 8, 2019

Auto merge of #63363 - ehuss:update-cargo, r=alexcrichton
Update cargo

9 commits in 26092da337b948719549cd5ed3d1051fd847afd7..42a8c0adf91323c01228268c651aef5366b25b69
2019-07-31 23:24:32 +0000 to 2019-08-07 20:41:07 +0000
- Add support for customizing JSON diagnostics from Cargo (rust-lang/cargo#7214)
- Bump rustfix (rust-lang/cargo#7221)
- Fix remap-path-prefix from failing. (rust-lang/cargo#7219)
- Clean up build script stuff and documentation. (rust-lang/cargo#7215)
- Remove debug panic in package-features. (rust-lang/cargo#7213)
- Fix an old test. (rust-lang/cargo#7208)
- Remove unused AstBuilder (rust-lang/cargo#7210)
- Revert "Release a jobserver token while locking a file" (rust-lang/cargo#7201)
- improve error message for unmatched prerelease dependencies (rust-lang/cargo#7191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.