Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow git+version dependency to be published. #7237

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@ehuss
Copy link
Contributor

commented Aug 12, 2019

This allows you to publish a dependency that specifies both git and version. The git value will be stripped out, just like a path dependency.

My original intent was to improve the error message, which was very confusing. I figured I might as well make git behave the same as path. I can change this PR to just reword the error instead of changing behavior if the new behavior isn't desired.

Closes #6738

@rust-highfive

This comment has been minimized.

Copy link

commented Aug 12, 2019

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Sounds reasonable to me! This is an expansion of stable behavior, so I'd like to check in with other folks as well

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

☔️ The latest upstream changes (presumably #7239) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss ehuss force-pushed the ehuss:git-with-version branch from da8aef4 to df639b9 Aug 12, 2019

@kevinis

This comment has been minimized.

Copy link

commented Aug 13, 2019

Once this is merged, I would be able to publish MesaLink on crates.io. This would benefit alexcrichton/curl-rust#280, too.

@rfcbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@Drevoed

This comment has been minimized.

Copy link

commented Aug 19, 2019

Is this going to be merged soon?

@ehuss

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

@bors r=alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

📌 Commit df639b9 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

⌛️ Testing commit df639b9 with merge d565c1e...

bors added a commit that referenced this pull request Aug 19, 2019

Auto merge of #7237 - ehuss:git-with-version, r=alexcrichton
Allow git+version dependency to be published.

This allows you to publish a dependency that specifies both `git` and `version`. The `git` value will be stripped out, just like a `path` dependency.

My original intent was to improve the error message, which was very confusing. I figured I might as well make `git` behave the same as `path`. I can change this PR to just reword the error instead of changing behavior if the new behavior isn't desired.

Closes #6738
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

💔 Test failed - checks-azure

@ehuss ehuss force-pushed the ehuss:git-with-version branch from df639b9 to d682439 Aug 19, 2019

@ehuss

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

@bors r=alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

📌 Commit d682439 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

⌛️ Testing commit d682439 with merge 93660b0...

bors added a commit that referenced this pull request Aug 19, 2019

Auto merge of #7237 - ehuss:git-with-version, r=alexcrichton
Allow git+version dependency to be published.

This allows you to publish a dependency that specifies both `git` and `version`. The `git` value will be stripped out, just like a `path` dependency.

My original intent was to improve the error message, which was very confusing. I figured I might as well make `git` behave the same as `path`. I can change this PR to just reword the error instead of changing behavior if the new behavior isn't desired.

Closes #6738
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 93660b0 to master...

@bors bors merged commit d682439 into rust-lang:master Aug 19, 2019

10 checks passed

homu Test successful
Details
rust-lang.cargo Build #20190819.11 succeeded
Details
rust-lang.cargo (Linux beta) Linux beta succeeded
Details
rust-lang.cargo (Linux nightly) Linux nightly succeeded
Details
rust-lang.cargo (Linux stable) Linux stable succeeded
Details
rust-lang.cargo (Windows x86_64-msvc) Windows x86_64-msvc succeeded
Details
rust-lang.cargo (docs) docs succeeded
Details
rust-lang.cargo (macOS) macOS succeeded
Details
rust-lang.cargo (resolver) resolver succeeded
Details
rust-lang.cargo (rustfmt) rustfmt succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.