Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when using API command with non-remote registry. #7239

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@ehuss
Copy link
Contributor

commented Aug 12, 2019

If you try to use an API command (publish, yank, search, etc.) with a source replacement active (like cargo-vendor or cargo-local-registry), then you get a really weird "failed to fetch" error. This adds a specific check to provide a slightly nicer error.

I'm not entirely happy with the wording, but I think it gets the point across.

@rust-highfive

This comment has been minimized.

Copy link

commented Aug 12, 2019

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@bors: r+

WFM

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

📌 Commit cce8742 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

⌛️ Testing commit cce8742 with merge 6aca041...

bors added a commit that referenced this pull request Aug 12, 2019
Auto merge of #7239 - ehuss:publish-non-remote-registry, r=alexcrichton
Improve error message when using API command with non-remote registry.

If you try to use an API command (publish, yank, search, etc.) with a source replacement active (like cargo-vendor or cargo-local-registry), then you get a really weird "failed to fetch" error. This adds a specific check to provide a slightly nicer error.

I'm not entirely happy with the wording, but I think it gets the point across.
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 6aca041 to master...

@bors bors merged commit cce8742 into rust-lang:master Aug 12, 2019

10 checks passed

homu Test successful
Details
rust-lang.cargo Build #20190812.5 succeeded
Details
rust-lang.cargo (Linux beta) Linux beta succeeded
Details
rust-lang.cargo (Linux nightly) Linux nightly succeeded
Details
rust-lang.cargo (Linux stable) Linux stable succeeded
Details
rust-lang.cargo (Windows x86_64-msvc) Windows x86_64-msvc succeeded
Details
rust-lang.cargo (docs) docs succeeded
Details
rust-lang.cargo (macOS) macOS succeeded
Details
rust-lang.cargo (resolver) resolver succeeded
Details
rust-lang.cargo (rustfmt) rustfmt succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.