Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`cargo install`: Remove orphaned executables. #7246

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@ehuss
Copy link
Contributor

commented Aug 13, 2019

When a new version of a package is installed that no longer contains an executable from a previous version, this change causes those orphaned executables to also be removed.

I can place this new behavior behind the install-upgrade feature gate if anyone is uncomfortable with changing the behavior now.

cc #6797

@rust-highfive

This comment has been minimized.

Copy link

commented Aug 13, 2019

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Seems reasonable to me! I'd propose leaving this as-is, so...

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@ehuss

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

@bors r=alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

📌 Commit 5a59b80 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

⌛️ Testing commit 5a59b80 with merge f42275c...

bors added a commit that referenced this pull request Aug 19, 2019

Auto merge of #7246 - ehuss:install-remove-orphan, r=alexcrichton
`cargo install`: Remove orphaned executables.

When a new version of a package is installed that no longer contains an executable from a previous version, this change causes those orphaned executables to also be removed.

I can place this new behavior behind the `install-upgrade` feature gate if anyone is uncomfortable with changing the behavior now.

cc #6797
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing f42275c to master...

@bors bors merged commit 5a59b80 into rust-lang:master Aug 19, 2019

10 checks passed

homu Test successful
Details
rust-lang.cargo Build #20190813.7 succeeded
Details
rust-lang.cargo (Linux beta) Linux beta succeeded
Details
rust-lang.cargo (Linux nightly) Linux nightly succeeded
Details
rust-lang.cargo (Linux stable) Linux stable succeeded
Details
rust-lang.cargo (Windows x86_64-msvc) Windows x86_64-msvc succeeded
Details
rust-lang.cargo (docs) docs succeeded
Details
rust-lang.cargo (macOS) macOS succeeded
Details
rust-lang.cargo (resolver) resolver succeeded
Details
rust-lang.cargo (rustfmt) rustfmt succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.