Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCompile deps with optimizations for benches #734
Conversation
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton, is there anything I can help with to get it into the nightly builds? |
This comment has been minimized.
This comment has been minimized.
brson
commented on 579971e
Oct 27, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
saw approval from brson |
This comment has been minimized.
This comment has been minimized.
|
merging alexcrichton/cargo/issue-728 = 579971e into auto-cargo |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
This comment has been minimized.
This comment has been minimized.
|
saw approval from brson |
This comment has been minimized.
This comment has been minimized.
|
saw approval from brson |
This comment has been minimized.
This comment has been minimized.
|
merging alexcrichton/cargo/issue-728 = 579971e into auto-cargo |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto-cargo = 9d3a7bd |
bors
added a commit
that referenced
this pull request
Oct 27, 2014
bors
added a commit
that referenced
this pull request
Oct 27, 2014
bors
added a commit
that referenced
this pull request
Oct 27, 2014
bors
merged commit 579971e
into
rust-lang:master
Oct 27, 2014
1 of 2 checks passed
continuous-integration/travis-ci
The Travis CI build failed
Details
default
all tests passed
alexcrichton
deleted the
alexcrichton:issue-728
branch
Oct 28, 2014
This comment has been minimized.
This comment has been minimized.
|
Thank you, @alexcrichton! Works beautifully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedOct 21, 2014
Previously only the local package was erroneously compiled with optimizations.
Closes #728