Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build libstd as a `dylib` #7353

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@alexcrichton
Copy link
Member

commented Sep 11, 2019

This commit forcibly prevents Cargo from building the std crate as a
dylib, even though libstd upstream lists a dylib crate type. We
ideally want a first-class feature for doing this one day, but for now
we can just hack around with the manifests to ensure that the dylib
crate type never shows up. Note that this is only supported for libstd,
and it's also all part of the unstable details of building std.

Closes rust-lang/wg-cargo-std-aware#35

@rust-highfive

This comment has been minimized.

Copy link

commented Sep 11, 2019

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

This commit forcibly prevents Cargo from building the `std` crate as a
`dylib`, even though libstd upstream lists a `dylib` crate type. We
ideally want a first-class feature for doing this one day, but for now
we can just hack around with the manifests to ensure that the `dylib`
crate type never shows up. Note that this is only supported for libstd,
and it's also all part of the unstable details of building std.

Closes rust-lang/wg-cargo-std-aware#35
@alexcrichton alexcrichton force-pushed the alexcrichton:libstd-no-dylib branch from 89a07e2 to 70bea01 Sep 11, 2019
@ehuss

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Should be fine for now.

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

📌 Commit 70bea01 has been approved by ehuss

bors added a commit that referenced this pull request Sep 11, 2019
Don't build libstd as a `dylib`

This commit forcibly prevents Cargo from building the `std` crate as a
`dylib`, even though libstd upstream lists a `dylib` crate type. We
ideally want a first-class feature for doing this one day, but for now
we can just hack around with the manifests to ensure that the `dylib`
crate type never shows up. Note that this is only supported for libstd,
and it's also all part of the unstable details of building std.

Closes rust-lang/wg-cargo-std-aware#35
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

⌛️ Testing commit 70bea01 with merge 4a58255...

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing 4a58255 to master...

@bors bors merged commit 70bea01 into rust-lang:master Sep 11, 2019
10 checks passed
10 checks passed
homu Test successful
Details
rust-lang.cargo Build #20190911.4 succeeded
Details
rust-lang.cargo (Linux beta) Linux beta succeeded
Details
rust-lang.cargo (Linux nightly) Linux nightly succeeded
Details
rust-lang.cargo (Linux stable) Linux stable succeeded
Details
rust-lang.cargo (Windows x86_64-msvc) Windows x86_64-msvc succeeded
Details
rust-lang.cargo (docs) docs succeeded
Details
rust-lang.cargo (macOS) macOS succeeded
Details
rust-lang.cargo (resolver) resolver succeeded
Details
rust-lang.cargo (rustfmt) rustfmt succeeded
Details
@alexcrichton alexcrichton deleted the alexcrichton:libstd-no-dylib branch Sep 16, 2019
@RalfJung

This comment has been minimized.

Copy link
Member

commented Sep 19, 2019

Could this be used by xargo somehow? We'd also be interested in rlib-only builds.

Cc rust-lang/rust#56443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.