Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on `winapi` 0.2 #7389

Merged
merged 1 commit into from Sep 19, 2019
Merged

Conversation

@alexcrichton
Copy link
Member

alexcrichton commented Sep 19, 2019

This commit removes Cargo's dependency on winapi 0.2 which takes an
excessively long time to build, slowing down Windows builds. The
winapi 0.2 crate was pulled in via a dependency chain that looked
like:

cargo
\- crates-io
   \- http
      \- bytes
         \- iovec
            \- winapi 0.2

The fix implemented here was to remove the http crate dependency from
crates-io which is only used for rendering status codes, but it's easy
enough to inline that function locally.

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Sep 19, 2019

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Sep 19, 2019

r? @Eh2406

@rust-highfive rust-highfive assigned Eh2406 and unassigned nrc Sep 19, 2019
This commit removes Cargo's dependency on `winapi` 0.2 which takes an
excessively long time to build, slowing down Windows builds. The
`winapi` 0.2 crate was pulled in via a dependency chain that looked
like:

    cargo
    \- crates-io
       \- http
          \- bytes
             \- iovec
                \- winapi 0.2

The fix implemented here was to remove the `http` crate dependency from
`crates-io` which is only used for rendering status codes, but it's easy
enough to inline that function locally.
@alexcrichton alexcrichton force-pushed the alexcrichton:less-winapi-02 branch from 37ce52a to 0f751de Sep 19, 2019
@Eh2406

This comment has been minimized.

Copy link
Contributor

Eh2406 commented Sep 19, 2019

r+ when ci is green

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Sep 19, 2019

@bors: r=Eh2406

That's what bors is for :)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Sep 19, 2019

📌 Commit 0f751de has been approved by Eh2406

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Sep 19, 2019

⌛️ Testing commit 0f751de with merge d3df047...

bors added a commit that referenced this pull request Sep 19, 2019
Remove dependency on `winapi` 0.2

This commit removes Cargo's dependency on `winapi` 0.2 which takes an
excessively long time to build, slowing down Windows builds. The
`winapi` 0.2 crate was pulled in via a dependency chain that looked
like:

    cargo
    \- crates-io
       \- http
          \- bytes
             \- iovec
                \- winapi 0.2

The fix implemented here was to remove the `http` crate dependency from
`crates-io` which is only used for rendering status codes, but it's easy
enough to inline that function locally.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Sep 19, 2019

☀️ Test successful - checks-azure
Approved by: Eh2406
Pushing d3df047 to master...

@bors bors merged commit 0f751de into rust-lang:master Sep 19, 2019
11 checks passed
11 checks passed
homu Test successful
Details
rust-lang.cargo Build #20190919.6 succeeded
Details
rust-lang.cargo (Linux beta) Linux beta succeeded
Details
rust-lang.cargo (Linux nightly) Linux nightly succeeded
Details
rust-lang.cargo (Linux stable) Linux stable succeeded
Details
rust-lang.cargo (Windows x86_64-msvc) Windows x86_64-msvc succeeded
Details
rust-lang.cargo (build_std) build_std succeeded
Details
rust-lang.cargo (docs) docs succeeded
Details
rust-lang.cargo (macOS) macOS succeeded
Details
rust-lang.cargo (resolver) resolver succeeded
Details
rust-lang.cargo (rustfmt) rustfmt succeeded
Details
@alexcrichton alexcrichton deleted the alexcrichton:less-winapi-02 branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.