Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --all-features in root of virtual workspace. #7525

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@ehuss
Copy link
Contributor

ehuss commented Oct 18, 2019

Accidentally restricted in #7507, pointed out by @hjmallon, --all-features flag is allowed in the root of a virtual workspace. Added a test to demonstrate its strange behavior.

For anyone that is curious, this line is the code responsible for this behavior.

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Oct 18, 2019

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Oct 18, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 18, 2019

📌 Commit 4d524ea has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 18, 2019

⌛️ Testing commit 4d524ea with merge 06ddf35...

bors added a commit that referenced this pull request Oct 18, 2019
…hton

Allow --all-features in root of virtual workspace.

Accidentally restricted in #7507, pointed out by @hjmallon, `--all-features` flag is allowed in the root of a virtual workspace.  Added a test to demonstrate its strange behavior.

For anyone that is curious, [this line](https://github.com/rust-lang/cargo/blob/3a9abe3f065554a7fbc59f440df2baba4a6e47ee/src/cargo/ops/resolve.rs#L302) is the code responsible for this behavior.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 18, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 06ddf35 to master...

@bors bors merged commit 4d524ea into rust-lang:master Oct 18, 2019
1 check passed
1 check passed
homu Test successful
Details
@ehuss ehuss referenced this pull request Oct 22, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 24, 2019
Update cargo

6 commits in 3a9abe3f065554a7fbc59f440df2baba4a6e47ee..3ba5f27170db10af7a92f2b682e049397197b8fa
2019-10-15 15:55:35 +0000 to 2019-10-22 15:05:18 +0000
- Fix typo in `cargo install --profile` help (rust-lang/cargo#7532)
- Use stricter -Z flag parsing. (rust-lang/cargo#7531)
- Set timestamp on generated files in archive to now (rust-lang/cargo#7523)
- Support rustc's `-Z panic-abort-tests` in Cargo (rust-lang/cargo#7460)
- rustfmt for nightly changes. (rust-lang/cargo#7526)
- Allow --all-features in root of virtual workspace. (rust-lang/cargo#7525)
Centril added a commit to Centril/rust that referenced this pull request Oct 24, 2019
Update cargo

6 commits in 3a9abe3f065554a7fbc59f440df2baba4a6e47ee..3ba5f27170db10af7a92f2b682e049397197b8fa
2019-10-15 15:55:35 +0000 to 2019-10-22 15:05:18 +0000
- Fix typo in `cargo install --profile` help (rust-lang/cargo#7532)
- Use stricter -Z flag parsing. (rust-lang/cargo#7531)
- Set timestamp on generated files in archive to now (rust-lang/cargo#7523)
- Support rustc's `-Z panic-abort-tests` in Cargo (rust-lang/cargo#7460)
- rustfmt for nightly changes. (rust-lang/cargo#7526)
- Allow --all-features in root of virtual workspace. (rust-lang/cargo#7525)
dignifiedquire added a commit to filecoin-project/rust-fil-proofs that referenced this pull request Oct 28, 2019
Need a fix for rust-lang/cargo#7525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.