Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize config-profile. #7823

Merged
merged 1 commit into from Jan 31, 2020
Merged

Stabilize config-profile. #7823

merged 1 commit into from Jan 31, 2020

Conversation

@ehuss
Copy link
Contributor

ehuss commented Jan 23, 2020

This is a proposal to stabilize config-profiles. This feature was proposed in RFC 2282 and implemented in #5506. Tracking issue is rust-lang/rust#48683.

This is intended to land in 1.43 which will reach the stable channel on April 23rd.

This is a fairly straightforward extension of profiles where the exact same syntax from Cargo.toml can be specified in a config file. Environment variables are supported for everything except the package override table, where we do not support the ability to read arbitrary keys in the environment name.

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Jan 23, 2020

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@ehuss

This comment has been minimized.

Copy link
Contributor Author

ehuss commented Jan 23, 2020

@rfcbot fcp merge

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jan 23, 2020

@rfcbot fcp merge

(trying again, I think you'll need the T-cargo tag)

@rfcbot

This comment has been minimized.

Copy link
Collaborator

rfcbot commented Jan 24, 2020

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link
Collaborator

rfcbot commented Jan 24, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jan 31, 2020

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 31, 2020

📌 Commit 8e935d4 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 31, 2020

⌛️ Testing commit 8e935d4 with merge f913212...

bors added a commit that referenced this pull request Jan 31, 2020
Stabilize config-profile.

This is a proposal to stabilize config-profiles. This feature was proposed in [RFC 2282](rust-lang/rfcs#2282) and implemented in #5506. Tracking issue is rust-lang/rust#48683.

This is intended to land in 1.43 which will reach the stable channel on April 23rd.

This is a fairly straightforward extension of profiles where the exact same syntax from `Cargo.toml` can be specified in a config file. Environment variables are supported for everything except the `package` override table, where we do not support the ability to read arbitrary keys in the environment name.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 31, 2020

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing f913212 to master...

@bors bors merged commit 8e935d4 into rust-lang:master Jan 31, 2020
11 checks passed
11 checks passed
homu Test successful
Details
rust-lang.cargo Build #20200123.4 succeeded
Details
rust-lang.cargo (Linux beta) Linux beta succeeded
Details
rust-lang.cargo (Linux nightly) Linux nightly succeeded
Details
rust-lang.cargo (Linux stable) Linux stable succeeded
Details
rust-lang.cargo (Windows x86_64-msvc) Windows x86_64-msvc succeeded
Details
rust-lang.cargo (build_std) build_std succeeded
Details
rust-lang.cargo (docs) docs succeeded
Details
rust-lang.cargo (macOS) macOS succeeded
Details
rust-lang.cargo (resolver) resolver succeeded
Details
rust-lang.cargo (rustfmt) rustfmt succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.