Add Visual Studio 2026 support #1609
Merged
+26
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
approved these changes
Nov 13, 2025
Contributor
NobodyXu
left a comment
NobodyXu
left a comment
There was a problem hiding this comment.
Thanks LGTM, cc @ChrisDenton can you have a look at this please?
ChrisDenton
approved these changes
Nov 13, 2025
Member
ChrisDenton
left a comment
ChrisDenton
left a comment
There was a problem hiding this comment.
This seems right to me. I did some testing to confirm it found both 2022 and 2026 correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to test everything, but a patched version of
cmake-rsis able to build projects using theVisual Studio 18 2026generator successfully.