Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lowering errors manually #276

Merged
merged 6 commits into from Nov 8, 2019

Conversation

@lnicola
Copy link
Contributor

lnicola commented Nov 5, 2019

Fixes #233, but there's one more failure in the tree via lalrpop -> (ascii-canvas ->) term -> dirs -> redox_users. Bumping term should fix it. See also https://rustsec.org/advisories/RUSTSEC-2018-0015.html.

Should be reviewed one commit at a time. Note that I might have messed up some of the messages. Sorry for the churn.

@lnicola

This comment has been minimized.

Copy link
Contributor Author

lnicola commented Nov 6, 2019

@matklad

This comment has been minimized.

Copy link
Member

matklad commented Nov 6, 2019

LGTM, though I don't have r+ in this repo. It might make sense to move errors out to a separate file, as there are a lot of them!

@lnicola lnicola force-pushed the lnicola:lowering-errors branch from e093d1a to 2e7bece Nov 6, 2019
@nikomatsakis

This comment has been minimized.

Copy link
Collaborator

nikomatsakis commented Nov 8, 2019

@lnicola this is awesome, but will have to be rebased -- we shuffled around the test file organization in #271. I hope it's not too painful, hopefully git should track everything successfully...? 🤞

@lnicola

This comment has been minimized.

Copy link
Contributor Author

lnicola commented Nov 8, 2019

Ah, no worries, I'll try to rebase it today.

@lnicola lnicola force-pushed the lnicola:lowering-errors branch from 2e7bece to 28eb384 Nov 8, 2019
@lnicola

This comment has been minimized.

Copy link
Contributor Author

lnicola commented Nov 8, 2019

I hope it's okay now.

@nikomatsakis Do you mind if I try to bump term in lalrpop and ascii-canvas? I think it needs a newer compiler version, I don't know what's your stance on that wrt. semver.

@nikomatsakis

This comment has been minimized.

Copy link
Collaborator

nikomatsakis commented Nov 8, 2019

@lnicola bump away, this crate is not semver stable at all

@nikomatsakis

This comment has been minimized.

Copy link
Collaborator

nikomatsakis commented Nov 8, 2019

Oh, you mean in ascii-canvas etc.

@nikomatsakis nikomatsakis merged commit 15e4416 into rust-lang:master Nov 8, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@lnicola lnicola deleted the lnicola:lowering-errors branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.