Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make chalk-rust-ir generic over type-family #284

merged 4 commits into from Nov 16, 2019


Copy link

nikomatsakis commented Nov 12, 2019

Building on #283, make the rust-ir types generic over type family.

@nikomatsakis nikomatsakis force-pushed the nikomatsakis:generic-rust-ir branch 3 times, most recently from b58c300 to 4faaa4c Nov 12, 2019

This comment has been minimized.

Copy link
Collaborator Author

nikomatsakis commented Nov 13, 2019

@tmandry, do you want to review?

I extended the PR now so that it extends the generics all the way through chalk-solve, which is probably as far as we want to go (I envision rustc eventually "hooking in" to chalk-solve).

The implementor of the RustIrDatabase can now select the type family.
The chalk-integration crate (and unit tests) use ChalkIr, but
everything else should be generic.
@nikomatsakis nikomatsakis force-pushed the nikomatsakis:generic-rust-ir branch from bd5a53a to 1b38304 Nov 14, 2019
Copy link

tmandry left a comment

LGTM! Excited to see what rustc integration will look like after this.

@nikomatsakis nikomatsakis merged commit a88cad7 into rust-lang:master Nov 16, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.