Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depth getting passed around #308

merged 1 commit into from Dec 13, 2019


Copy link

jackh726 commented Dec 12, 2019

Followup work from recursive removal

This simplifies logic a bit because we actually don't need to pass around depth at all.

There's a few other things I want to do with chalk-engine as followup to the recursive removal. Don't want to block this PR on them, but if this doesn't get merged before I finish them, I'll just change this PR for them.

Copy link

nikomatsakis left a comment

This definitely seems cleaner, yes.

@nikomatsakis nikomatsakis merged commit ee4b0f3 into rust-lang:master Dec 13, 2019
3 checks passed
3 checks passed
Test (stable)
Test (nightly)
@jackh726 jackh726 deleted the jackh726:nodepth branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.