Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __rust_probestack intrinsic #175

Merged
merged 1 commit into from Jul 6, 2017
Merged

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Jul 6, 2017

Will be required for rust-lang/rust#42816

@alexcrichton
Copy link
Member Author

alexcrichton commented Jul 6, 2017

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 6, 2017

📌 Commit f638229 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 6, 2017

Testing commit f638229 with merge 7e3aa90...

bors added a commit that referenced this pull request Jul 6, 2017
Add `__rust_probestack` intrinsic

Will be required for rust-lang/rust#42816
@bors
Copy link
Contributor

bors commented Jul 6, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

alexcrichton commented Jul 6, 2017

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 6, 2017

📌 Commit 7ccf840 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 6, 2017

Testing commit 7ccf840 with merge e9b258b...

bors added a commit that referenced this pull request Jul 6, 2017
Add `__rust_probestack` intrinsic

Will be required for rust-lang/rust#42816
@mattico
Copy link
Contributor

mattico commented Jul 6, 2017

Just curious: does this obsolete ___chkstk_ms? Was that even used in the first place?

@alexcrichton
Copy link
Member Author

alexcrichton commented Jul 6, 2017

Nah we'll still need to keep those around. On non-Windows platforms __rust_probestack will be used but on Windows the __chkstk business is still used.

It may, however, make sense to consolidate all these intrinsics in one module

@bors
Copy link
Contributor

bors commented Jul 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing e9b258b to master...

@bors bors merged commit 7ccf840 into rust-lang:master Jul 6, 2017
@alexcrichton alexcrichton deleted the probestack branch May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants