Skip to content
This repository has been archived by the owner. It is now read-only.

Workaround LLVM bug 11663 #27

Merged
merged 1 commit into from Nov 18, 2016

Conversation

@xen0n
Copy link

@xen0n xen0n commented Nov 18, 2016

Based on this FreeBSD commit, with modification to accomodate the way MIPS ABI is presented on Linux.

Based on [this FreeBSD commit][freebsd-commit], with modification to
accomodate the way MIPS ABI is presented on Linux.

[freebsd-commit]: https://svnweb.freebsd.org/base/head/contrib/compiler-rt/lib/builtins/int_lib.h?r1=276789&r2=276851
@alexcrichton alexcrichton merged commit 314d8fb into rust-lang:rust-llvm-2016-07-18 Nov 18, 2016
@xen0n xen0n deleted the xen0n:dont-recurse branch Nov 18, 2016
@alexcrichton alexcrichton mentioned this pull request Apr 18, 2017
5 of 5 tasks complete
TimNN added a commit that referenced this pull request Apr 23, 2017
TimNN added a commit that referenced this pull request Jul 20, 2017
@glaubitz
Copy link

@glaubitz glaubitz commented Jan 30, 2018

@alexcrichton I am seeing these stack overflows on Linux/sparc64 again:

running: /usr/bin/cargo build --manifest-path /home/glaubitz/rust/rustc-1.23.0+dfsg1/src/bootstrap/Cargo.toml --verbose --
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/usr/bin/rustc - --crate-name ___ --print=file-names -C link-args=-Wl,-z,relro -Zrema0+dfsg1 -Zremap-path-prefix-to=/usr/src/rustc-1.23.0 --target sparc64-unknown-linux-gnu --crate-type bin --crate-type proccess abort signal)
--- stderr

thread 'rustc' has overflowed its stack
fatal runtime error: stack overflow

Looking at lib/builtins/int_lib.h, this particular workaround is missing again.

So, I guess we need to reimport #27, #28, #31, #33 and #34 as LLVM upstream still hasn't fixed this bug (https://bugs.llvm.org/show_bug.cgi?id=11663).

@glaubitz
Copy link

@glaubitz glaubitz commented Jan 30, 2018

I created #35 for convenience. With the #35 merged, the problem goes away again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants