Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd initial draft of crates policy. #19
Conversation
michaelwoerister
reviewed
Mar 1, 2019
procedures/crates.md Outdated
michaelwoerister
reviewed
Mar 1, 2019
procedures/crates.md Outdated
michaelwoerister
reviewed
Mar 1, 2019
procedures/crates.md Outdated
michaelwoerister
reviewed
Mar 1, 2019
procedures/crates.md Outdated
This comment has been minimized.
This comment has been minimized.
|
Thanks for writing up the draft, @davidtwco! I added some remarks about questions that I expect to arise. |
davidtwco
reviewed
Mar 1, 2019
procedures/crates.md Outdated
This comment has been minimized.
This comment has been minimized.
|
For those following along at home, there's discussion about this draft policy - desired changes and additions - in this Zulip thread. |
pietroalbini
reviewed
Mar 1, 2019
procedures/crates.md Outdated
davidtwco
added some commits
Mar 2, 2019
This comment has been minimized.
This comment has been minimized.
|
I've rewritten most of the policy based on the review comments and yesterday's steering meeting discussions, would appreciate more feedback. |
nagisa
reviewed
Mar 2, 2019
procedures/crates.md Outdated
michaelwoerister
reviewed
Mar 6, 2019
procedures/crates.md Outdated
nikomatsakis
reviewed
Mar 8, 2019
|
Looks great. Left some thoughts. Thanks for doing this @davidtwco |
davidtwco
force-pushed the
davidtwco:crates-policy-draft
branch
from
7757ffa
to
fce13c8
Mar 9, 2019
Centril
reviewed
Mar 9, 2019
procedures/crates.md Outdated
procedures/crates.md Outdated
Centril
and others
added some commits
Mar 9, 2019
davidtwco
marked this pull request as ready for review
Mar 12, 2019
davidtwco
assigned
nikomatsakis
Mar 12, 2019
Centril
approved these changes
Mar 12, 2019
|
Looks great; thanks for the changes :) |
nikomatsakis
approved these changes
Mar 13, 2019
nikomatsakis
merged commit b235441
into
rust-lang:master
Mar 13, 2019
davidtwco
deleted the
davidtwco:crates-policy-draft
branch
Mar 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
davidtwco commentedMar 1, 2019
•
edited
I've tried to write up what was discussed and in the notes from the All Hands' organizational meeting. There are a handful of areas that need elaborated on and might not make complete sense as it is but was mentioned in the notes from the meeting. I'd appreciate any further ideas or feedback.