Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish out-of-tree crates policy. #68

Merged

Conversation

Projects
None yet
6 participants
@davidtwco
Copy link
Member

commented Apr 21, 2019

Fixes #57. There are still some unresolved questions, but we can work out the right answers in the PR comments.

cc @michaelwoerister (the additions are based on your work with measureme).

Show resolved Hide resolved procedures/crates.md Outdated
Show resolved Hide resolved procedures/crates.md
Show resolved Hide resolved procedures/crates.md Outdated
Show resolved Hide resolved procedures/crates.md
@michaelwoerister

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Looks great, thanks @davidtwco!

Show resolved Hide resolved procedures/crates.md Outdated
Show resolved Hide resolved procedures/crates.md Outdated
Modify suggested permissions of compiler team.
Co-Authored-By: davidtwco <in@davidtw.co>
@Centril

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

One thing that I'd like to see in the out-of-crates policy is that anything that comes close to "stabilization" or "a change in semantics" in the language should always be decided on rust-lang/rust. I don't want to have to dig into submodule or crate update PRs to see if anything important, relnotes relevant, or T-Lang relevant has happened in the update.

@davidtwco

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

One thing that I'd like to see in the out-of-crates policy is that anything that comes close to "stabilization" or "a change in semantics" in the language should always be decided on rust-lang/rust. I don't want to have to dig into submodule or crate update PRs to see if anything important, relnotes relevant, or T-Lang relevant has happened in the update.

I've added some wording to this effect.

@davidtwco davidtwco requested a review from nikomatsakis Apr 27, 2019

Show resolved Hide resolved procedures/crates.md Outdated

@davidtwco davidtwco force-pushed the davidtwco:finish-out-of-tree-crates-policy branch from d20c1b4 to 95fd9c2 Apr 27, 2019

@nikomatsakis nikomatsakis merged commit aed1906 into rust-lang:master May 2, 2019

@davidtwco davidtwco deleted the davidtwco:finish-out-of-tree-crates-policy branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.