This repository was archived by the owner on Nov 13, 2022. It is now read-only.
Block unblock ips #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com> refactors parse_config_value_set into a more central place Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com> wip Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com> refactor Signed-off-by: Nell Shamrell <nellshamrell@gmail.com> more refactoring Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com> wip Signed-off-by: Nell Shamrell <nellshamrell@gmail.com> Revert "wip" This reverts commit 95a47e6. wip Signed-off-by: Nell Shamrell <nellshamrell@gmail.com> wip Signed-off-by: Nell Shamrell <nellshamrell@gmail.com> Revert "wip" This reverts commit 7903072. Revert "wip" This reverts commit 5344822.
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com> modifies parsing a hashset into a string so that it does not create an empty string at the beginning Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
nellshamrell
force-pushed
the
block-unblock-ips
branch
from
89949bd to
b20202e
Compare
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Collaborator
Author
|
@pietroalbini @smarnach your feedback has been so helpful on previous pull requests, I would LOVE if you would take a look at this one when you have some time. |
pietroalbini
suggested changes
Apr 10, 2020
…_app_config command Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
…OCKED_IPS env var Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
… per command Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
…s are currently blocked Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
Collaborator
Author
|
Thank you for the review, @pietroalbini ! I believe I've addressed all your comments. |
pietroalbini
approved these changes
Apr 14, 2020
smarnach
approved these changes
Apr 14, 2020
Contributor
smarnach
left a comment
smarnach
left a comment
There was a problem hiding this comment.
This is looking good to me.
I still think that we want to allow ops people to see the current value of the blocked IPs, but this is easy to change, so we can decide this when needed.
README.md
Outdated
|
|
||
| ``` | ||
| you: ~block_ip testing-nell-bot 123.456.68 | ||
| crates-io-bot: @you IP address 123.456.789 |
Contributor
There was a problem hiding this comment.
I guess the bot should reply with the same address as the one in the request.
Collaborator
Author
There was a problem hiding this comment.
er...yes...fixing the doc!
| params: empty_config_var(), | ||
| }); | ||
|
|
||
| let response_err = response.is_err(); |
Contributor
There was a problem hiding this comment.
You can inline this variable – it's used only once.
src/utilities.rs
Outdated
| value_set.insert(String::from(string)); | ||
| } | ||
|
|
||
| value_set |
Contributor
There was a problem hiding this comment.
It looks like this function body is equivalent to
config_value.split(',').map(String::from).collect()
src/utilities.rs
Outdated
| // Remove last comma | ||
| combined_string.pop(); | ||
|
|
||
| combined_string |
Contributor
There was a problem hiding this comment.
More concise alternative:
let non_empty: Vec<String> = config_value.into_iter().filter(|s| !s.is_empty()).collect();
non_empty.join(",")
There is not join() for arbitrary iterators of strings, so we need to collect into a vector first.
Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command to block an ip address and a command to unblock an ip address, according to the requirements in #4.