Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPlease use a little more width for crate pages on screens #970
Comments
carols10cents
added
C-enhancement
A-ui
labels
Aug 19, 2017
carols10cents
added
the
A-CSS
label
Sep 4, 2017
carols10cents
added
E-easy
E-help-wanted
E-mentor
WG-infra-crates.io
labels
Sep 15, 2017
carols10cents
added this to the
impl period milestone
Sep 15, 2017
carols10cents
added
the
T-infra
label
Sep 15, 2017
carols10cents
removed this from the
impl period milestone
Sep 15, 2017
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@tcbyrd I think the right solution would be to widen the containing div as well (the beige area) and leave the authorship sidebar the same size. Some other pages already have a wider content area. |
This comment has been minimized.
This comment has been minimized.
|
I agree. 960px is a pretty decent width for the whole thing. I pulled down the source and noticed this doesn't change the docs because they are hosted on GitHub Pages. To make it consistent we'd also need to change this line in Since I already setup the dev environment, I'll open a PR tomorrow unless I hear otherwise. |
tcbyrd
referenced this issue
Sep 19, 2017
Merged
Make the page wider to give more room for README on desktop #1064
bors-voyager bot
added a commit
that referenced
this issue
Sep 21, 2017
bors-voyager
bot
closed this
in
#1064
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment

joshtriplett commentedAug 19, 2017
•
edited by carols10cents
When rendering on a full-size screen (rather than mobile), the crates page still renders content in a very narrow column. The width used on almost every other page seems fine, but crate pages have a sidebar, which narrows the region available for the README content.
Take a look at https://crates.io/crates/colorparse, and compare it to https://github.com/joshtriplett/colorparse/. Notice how the code in the latter doesn't wrap, while it does in the former.
I think it would be reasonable for the main (non-sidebar) crate content on crate pages to have the same width that the overall (non-columnar) content has on other pages. That would make the README much more readable, without sacrificing the critical property of avoiding excessively wide lines.
Does that seem reasonable?
Implementation instructions added by @carols10cents:
max-widthset on.crate-info .docs(I think) so that it's about as wide as readmes appear on GitHubnpm run start:livewill come in handy for this :)