controllers/summary: Use tokio::try_join!() to perform database queries in parallel
#10082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries in parallel
Turbo87
added
C-enhancement ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #9663, this PR changes our
GET /api/v1/summaryendpoint to perform various SQL queries in parallel.In local testing this brought the average response time from around 100ms down to 80ms 🎉
Unfortunately, the
encode_crates()calls currently still need to be a separate step, since we can't keep hold of the&mut connacrossawaitpoints when we're sharing the connection... or at least I haven't found a way yet 🤷♂️Related: