Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 27, 2024

This PR adjusts our BackgroundJob::enqueue() fn to be able to take advantage of Postgres query pipelining and then uses it in various places to reduce the amount of waiting for queries to be finished.

Related:

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 27, 2024
@Turbo87 Turbo87 requested a review from a team November 27, 2024 14:45
@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 59.03614% with 34 lines in your changes missing coverage. Please review.

Project coverage is 89.35%. Comparing base (f88a3eb) to head (289be81).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/bin/crates-admin/delete_crate.rs 0.00% 10 Missing ⚠️
src/bin/crates-admin/yank_version.rs 0.00% 8 Missing ⚠️
src/controllers/krate/publish.rs 75.00% 8 Missing ⚠️
src/bin/crates-admin/delete_version.rs 0.00% 7 Missing ⚠️
crates/crates_io_worker/src/background_job.rs 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10087      +/-   ##
==========================================
- Coverage   89.37%   89.35%   -0.03%     
==========================================
  Files         294      294              
  Lines       31283    31308      +25     
==========================================
+ Hits        27960    27975      +15     
- Misses       3323     3333      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I also am not going to pretend to be fully across all the nuances of async Diesel.

@Turbo87 Turbo87 merged commit 67354ac into rust-lang:main Nov 29, 2024
10 checks passed
@Turbo87 Turbo87 deleted the pipelined-enqueue branch November 29, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants