Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 29, 2024

The "invalid authentication" check (see #10104) was actually resulting in a false-positive, since the request payload was small enough to not trigger the Cloudfront bug. This commit adjusts the smoke test to generate a 15 MB dummy file which we then try to publish instead.

Related:

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 29, 2024
The "invalid authentication" check was actually resulting in a false-positive, since the request payload was small enough to not trigger the Cloudfront bug. This commit adjusts the smoke test to generate a 15 MB dummy file which we then try to publish instead.
@Turbo87 Turbo87 enabled auto-merge (squash) November 29, 2024 11:42
@codecov
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 89.37%. Comparing base (e6ec730) to head (e0afe0c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/crates_io_smoke_test/src/main.rs 0.00% 61 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10106      +/-   ##
==========================================
- Coverage   89.45%   89.37%   -0.08%     
==========================================
  Files         294      294              
  Lines       31256    31283      +27     
==========================================
+ Hits        27959    27960       +1     
- Misses       3297     3323      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit 60ac9f4 into rust-lang:main Nov 29, 2024
10 checks passed
@Turbo87 Turbo87 deleted the smoke-test branch November 29, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant