Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the page wider to give more room for README on desktop #1064
Conversation
tcbyrd
added some commits
Sep 19, 2017
carols10cents
added
the
S-waiting-on-review
label
Sep 20, 2017
This comment has been minimized.
This comment has been minimized.
|
Welcome!! This looks great!! I love the gifs showing the difference too bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
bors: r+ let's try this again |
bors-voyager bot
added a commit
that referenced
this pull request
Sep 21, 2017
This comment has been minimized.
This comment has been minimized.
Build succeeded |
bors-voyager
bot
merged commit 835868c
into
rust-lang:master
Sep 21, 2017
2 checks passed
bors
Build succeeded
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Turbo87
removed
the
S-waiting-on-review
label
Dec 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tcbyrd commentedSep 19, 2017
•
edited
Fixes #970
Summary
This is my first PR to this repo, but I saw the Issue above and thought I'd try and tackle it since it's fairly minimal, but is a nice change to help with readability. This is a suggestion to widen the width of the main div to 960px so that the
.crate-info .docsdiv can be increased a bit without having to decrease the size of the.crate-info .authorshipdiv.Reasoning
I mainly chose 960px since it's a fairly widely accepted standard for content of this type. This allows the documentation to be 640px, which increases the line-length of the
preelements to 65 to help minimize horizontal scrolling.Before/After

Other Changes
I also changed the responsive screen width option to match the 960px width. The only major side effect here is the authorship div gets a little narrow until it switches to 100% at 900px, but that was already happening at 1040px and it's still readable. The other option is to leave it at 960px and just let the whole page horizontally scroll from 900-960px.
Example of the narrow authorship div @ 915px

Docs Updates
If the team wants to accept this change, for the docs to be consistent, this line in the GitHub pages branch of the Cargo repo will also need to be updated.
I saw there were some discussions about a much bigger redesign, but I thought this may help in the interim since it's a fairly minimal change. I'm open to any feedback!😄