Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable syntax highlighting. #1070

Merged
merged 1 commit into from Sep 23, 2017

Conversation

Projects
None yet
3 participants
@treiff
Copy link
Contributor

treiff commented Sep 21, 2017

Syntax highlighting seems to be working as intended now. I tested by publishing a create locally with a README.md including a couple of code samples, see below for a screenshot. Thanks for the help, and please let me know if you have any questions.

Closes #1008

screen shot 2017-09-21 at 1 07 28 pm

Re-enable syntax highlighting.
- Added `code` tag and corresponding `class` attribute to the whitelisted `tag_attributes`.
- Added `allowed-classes` for the `code` tag.

Test for adding classes to non whitelisted tags.
@sgrif

sgrif approved these changes Sep 21, 2017

Copy link
Contributor

sgrif left a comment

LGTM but @carols10cents should take a look at this before it's merged.

@carols10cents

This comment has been minimized.

Copy link
Member

carols10cents commented Sep 23, 2017

Looks great!! Thank you!! 🔴 🔵 ⚫️ ⚪️

bors: r+

bors-voyager bot added a commit that referenced this pull request Sep 23, 2017

Merge #1070
1070: Re-enable syntax highlighting. r=carols10cents

Syntax highlighting seems to be working as intended now.  I tested by publishing a create locally with a `README.md` including a couple of code samples, see below for a screenshot. Thanks for the help, and please let me know if you have any questions.

Closes #1008 

<img width="963" alt="screen shot 2017-09-21 at 1 07 28 pm" src="https://user-images.githubusercontent.com/5225538/30719271-d79969e8-9ef0-11e7-878d-064a62a4dbeb.png">
@bors-voyager

This comment has been minimized.

Copy link
Contributor

bors-voyager bot commented Sep 23, 2017

@bors-voyager bors-voyager bot merged commit 164f0d8 into rust-lang:master Sep 23, 2017

2 checks passed

bors Build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@treiff treiff deleted the treiff:re-enable-syntax-highlighting branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.