New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #1031 - Branding updates for crates.io #1098

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
5 participants
@SeanPrashad
Copy link
Contributor

SeanPrashad commented Oct 1, 2017

Modified the <h1> header inside app/templates/index.hbs from "The Rust community’s crate host" to "The Rust community’s crate registry".

@SeanPrashad SeanPrashad referenced this pull request Oct 1, 2017

Closed

Branding updates for crates.io #1031

2 of 2 tasks complete
@behnam

This comment has been minimized.

Copy link
Contributor

behnam commented Oct 1, 2017

Thanks, @SeanPrashad. The change looks good, but I think we better check something before landing, based on my experience from changing the tagline in the header.

The current text, "The Rust community’s crate host", fits one line in most views/browsers. Since "registry" is a wider word than "host" (regularly), I think we want to check if the new sentence also fits in one line.

I just made the change using Developer Tools in my browser and it still fits one line. Would you double-check that on your side, so we don't have to patch it again if it doesn't fit.

(If it doesn't fit in one line, we need to reduce the size of the text a bit.)

@behnam

behnam approved these changes Oct 1, 2017

@SeanPrashad

This comment has been minimized.

Copy link
Contributor Author

SeanPrashad commented Oct 1, 2017

Thanks for that heads up @behnam - I'm not sure how to go about using Developer Tools in my browser to view/modify the font size/placement, or to actually run crates.io locally - is there any documentation that I could read to figure out both of the above?

Edit: I modified the HTML locally on the crates.io website to use "registry" instead of "host" and it is fitting on one line (MacOS with Chrome Version 61.0.3163.100 - 64 bit).

Edit 2: Fitting on a single line in Safari Version 11.0 (12604.1.38.1.7).

@behnam

This comment has been minimized.

Copy link
Contributor

behnam commented Oct 1, 2017

This is Chrome's DevTools docs: https://developer.chrome.com/devtools

This is how to run a local server for the crates.io app: https://guides.emberjs.com/v2.15.0/getting-started/quick-start/

Since you've already tested in a couple of browsers, (and I've checked it in Chrome/Linux, and it looks good) I think we're good to go. @carols10cents?

@jtgeibel

This comment has been minimized.

Copy link
Member

jtgeibel commented Oct 2, 2017

We should also keep in mind rust-lang/cargo#4208. As far as I can tell, the intent (after a depreciation cycle) is to allow people to pass something like --host https://crates.io so we may want to keep the existing nomenclature or change it back after that lands.

@behnam

This comment has been minimized.

Copy link
Contributor

behnam commented Oct 2, 2017

Thanks, @jtgeibel, for bringing that up. In #950, we had a little discussion about it, but the issue of --host didn't come up then.

In RFC 2141, such a service is clearly named "registry". The keyword used in the CLI is --index in that RFC.

And recently there's been PRs to replace --host with --index, like rust-lang/cargo#4208 and rust-lang/cargo#4209.

So, I think it's safe to say that we want to call crates.io the "package registry" and not "package host" anymore.

@carols10cents

This comment has been minimized.

Copy link
Member

carols10cents commented Oct 5, 2017

This looks great to me! Thank you!!

bors: r+

bors-voyager bot added a commit that referenced this pull request Oct 5, 2017

Merge #1098
1098: Resolves #1031 - Branding updates for crates.io r=carols10cents

Modified the `<h1>` header inside `app/templates/index.hbs` from "The Rust community’s crate **host**" to "The Rust community’s crate **registry**".
@bors-voyager

This comment has been minimized.

Copy link
Contributor

bors-voyager bot commented Oct 5, 2017

@bors-voyager bors-voyager bot merged commit 17e797a into rust-lang:master Oct 5, 2017

2 checks passed

bors Build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SeanPrashad

This comment has been minimized.

Copy link
Contributor Author

SeanPrashad commented Oct 5, 2017

@behnam @carols10cents Although the commit has been merged successfully, I still see "host" being used on crates.io instead of "registry". Did we miss something?

@carols10cents

This comment has been minimized.

Copy link
Member

carols10cents commented Oct 5, 2017

Oh we don't have auto-deploy or anything. This'll go out when I next deploy, probably later today. Thanks!

@carols10cents

This comment has been minimized.

Copy link
Member

carols10cents commented Oct 10, 2017

I lied, it went out today because of Reasons! It's out now-- you might have to do a shift-reload to clear browser cache, but I see it :) Thank you @SeanPrashad!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment