Skip to content

database: Use SQL ordering in calculate_default_version() #12273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

database: Use SQL ordering in calculate_default_version() #12273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions crates/crates_io_database/src/models/default_versions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use crate::schema::{default_versions, versions};
use crates_io_diesel_helpers::SemverVersion;
use diesel::dsl::jsonb_typeof;
use diesel::prelude::*;
use diesel_async::{AsyncPgConnection, RunQueryDsl};
use tracing::{debug, instrument, warn};
Expand Down Expand Up @@ -119,17 +120,21 @@ async fn calculate_default_version(
crate_id: i32,
conn: &mut AsyncPgConnection,
) -> QueryResult<Version> {
use diesel::result::Error::NotFound;

debug!("Loading all versions for the crate…");
let versions = Version::query()
debug!("Loading default version for the crate…");
Version::query()
.filter(versions::crate_id.eq(crate_id))
.load(conn)
.await?;

debug!("Found {} versions", versions.len());

versions.into_iter().max().ok_or(NotFound)
.order((
// 1. Non-yanked first
versions::yanked,
// 2. Non-prerelease first
jsonb_typeof(versions::semver_ord.retrieve_as_object(3)).eq("array"),
// 3. Higher semver first
versions::semver_ord.desc(),
// 4. Higher ID first as tie-breaker
versions::id.desc(),
))
.first(conn)
.await
}

#[cfg(test)]
Expand Down