New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email verification warning #1565

Merged
merged 3 commits into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@carols10cents
Member

carols10cents commented Nov 29, 2018

This is the start of the implementation of rust-lang/crates-io-cargo-teams#8.

We can start warning now; if folks are using nightly, cargo will show it. Next release, beta will show it, and then the release after that, stable will show it. We have until the release after THAT to implement the hard error. I think. If I've counted correctly.

carols10cents and others added some commits Nov 29, 2018

Share structs between controller and tests
Changed from .contains() to .first().unwrap() == in tests because
contains is weird rust-lang/rust#42671
@jtgeibel

This comment has been minimized.

Member

jtgeibel commented Nov 30, 2018

I tested this in staging with nightly cargo and got the expected warning. Looks great!

bors: r+

bors-voyager bot added a commit that referenced this pull request Nov 30, 2018

Merge #1565
1565: Email verification warning r=jtgeibel a=carols10cents

This is the start of the implementation of rust-lang/crates-io-cargo-teams#8. 

We can start warning now; if folks are using nightly, cargo will show it. Next release, beta will show it, and then the release after that, stable will show it. We have until the release after THAT to implement the hard error. I think. If I've counted correctly.

Co-authored-by: Carol (Nichols || Goulding) <carol.nichols@gmail.com>
Co-authored-by: Justin Geibel <jtgeibel@gmail.com>
@bors-voyager

This comment has been minimized.

Contributor

bors-voyager bot commented Nov 30, 2018

@bors-voyager bors-voyager bot merged commit d9e5291 into rust-lang:master Nov 30, 2018

3 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
percy/crates.io Visual review automatically approved, no visual changes found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment