New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark API tokens as revoked #1567

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@joshleeb
Copy link
Contributor

joshleeb commented Nov 30, 2018

With this PR, when a user deletes an API token, rather than deleting it from the database, it will instead be marked as revoked.

That means that this PR also adds a migration to add the column revoked to the api_tokens table.

Ref. #1548 (Task 1)

Mark API tokens as revoked
With this PR, when a user deletes an API token, rather than deleting it
from the database, it will instead be marked as `revoked`.

That means that this PR also adds a migration to add the column
`revoked` to the `api_tokens` table.

@joshleeb joshleeb force-pushed the joshleeb:revoked-api-tokens branch from fcb1ba5 to 359ec94 Dec 1, 2018

@carols10cents

This comment has been minimized.

Copy link
Member

carols10cents commented Dec 3, 2018

Thanks! Looks great!!!

bors: r+

bors-voyager bot added a commit that referenced this pull request Dec 3, 2018

Merge #1567
1567: Mark API tokens as revoked r=carols10cents a=joshleeb

With this PR, when a user deletes an API token, rather than deleting it from the database, it will instead be marked as `revoked`.

That means that this PR also adds a migration to add the column `revoked` to the `api_tokens` table.

Ref. #1548 (Task 1)

Co-authored-by: Josh Leeb-du Toit <josh.leebdutoit@gmail.com>
@bors-voyager

This comment has been minimized.

Copy link
Contributor

bors-voyager bot commented Dec 3, 2018

@bors-voyager bors-voyager bot merged commit 359ec94 into rust-lang:master Dec 3, 2018

3 checks passed

bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
percy/crates.io Visual review automatically approved, no visual changes found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment