Initialize a single reqwest::Client for the server process
#1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `reqwest::Client` represents a pool of connections and should be reused. For the `server` and `render-readme` binaries, a single pool is now used for all requests. This should reduce allocation activity in production for routes that make an outgoing HTTP connection. Each initialization costs 30,255 allocations and 2.0 MB of allocated data. This work is also done on a new thread which will map it to a random jemalloc arena. The initialization is now done once when the server is booted and any remaining per-request allocations will occur on a smaller thread pool. This also cleans up how proxying is implemented when running tests. Previously, the configuration was stored in the S3 `Uploader` but this resulted in test failures when calling functions (i.e. `crate_location` and `readme_location`) that do not make an HTTP request.
Contributor
|
@bors r+ |
Contributor
|
📌 Commit 96c8559 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Mar 20, 2019
Initialize a single `reqwest::Client` for the server process A `reqwest::Client` represents a pool of connections and should be reused. For the `server` and `render-readme` binaries, a single pool is now used for all requests. This should reduce allocation activity in production for routes that make an outgoing HTTP connection. Each initialization costs 30,255 allocations and 2.0 MB of allocated data. This work is also done on a new thread which will map it to a random jemalloc arena. The initialization is now done once when the server is booted and any remaining per-request allocations will occur on a smaller thread pool. This also cleans up how proxying is implemented when running tests. Previously, the configuration was stored in the S3 `Uploader` but this resulted in test failures when calling functions (i.e. `crate_location` and `readme_location`) that do not make an HTTP request.
Contributor
|
☀️ Test successful - checks-travis |
This was referenced Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
reqwest::Clientrepresents a pool of connections and should bereused. For the
serverandrender-readmebinaries, a single poolis now used for all requests.
This should reduce allocation activity in production for routes that
make an outgoing HTTP connection. Each initialization costs 30,255
allocations and 2.0 MB of allocated data. This work is also done on a
new thread which will map it to a random jemalloc arena. The
initialization is now done once when the server is booted and any
remaining per-request allocations will occur on a smaller thread pool.
This also cleans up how proxying is implemented when running tests.
Previously, the configuration was stored in the S3
Uploaderbut thisresulted in test failures when calling functions (i.e.
crate_locationand
readme_location) that do not make an HTTP request.