Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audit trail to the publish, yank and unyank transactions. #1700

Merged
merged 6 commits into from Dec 2, 2019

Conversation

@markcatley
Copy link
Contributor

markcatley commented Mar 31, 2019

Contributes to Issue 1548
Based on the commits from PR 1604

src/models/action.rs Outdated Show resolved Hide resolved
@markcatley

This comment has been minimized.

Copy link
Contributor Author

markcatley commented Mar 31, 2019

What recommendations would you have on what should be unit tested?

@markcatley markcatley force-pushed the markcatley:version-owner-actions branch 2 times, most recently from 5da6778 to d03686b Mar 31, 2019
src/models/action.rs Outdated Show resolved Hide resolved
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 1, 2019

☔️ The latest upstream changes (presumably #1677) made this pull request unmergeable. Please resolve the merge conflicts.

@markcatley markcatley force-pushed the markcatley:version-owner-actions branch 3 times, most recently from bae2a11 to 5c8db82 Apr 1, 2019
@markcatley markcatley force-pushed the markcatley:version-owner-actions branch from 5c8db82 to 0fbb832 May 3, 2019
@markcatley markcatley force-pushed the markcatley:version-owner-actions branch 2 times, most recently from 79ce0b6 to 15856bc May 3, 2019
src/models/action.rs Outdated Show resolved Hide resolved
src/models/token.rs Outdated Show resolved Hide resolved
src/models/action.rs Outdated Show resolved Hide resolved
@sgrif

This comment has been minimized.

Copy link
Contributor

sgrif commented May 13, 2019

I'd like to see some integration tests for this as well

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 5, 2019

☔️ The latest upstream changes (presumably #1599) made this pull request unmergeable. Please resolve the merge conflicts.

@markcatley markcatley force-pushed the markcatley:version-owner-actions branch 4 times, most recently from c4db368 to 6a0c3e6 Oct 7, 2019
@markcatley

This comment has been minimized.

Copy link
Contributor Author

markcatley commented Oct 7, 2019

Sorry that I left this alone for so long. I noticed that @carols10cents merged PR 1604 that this was based on so I've updated this PR and made the changes suggested.

Some of the changes @sgrif made are related to code that's already been merged. I have not made these, and @carols10cents and @sgrif will have to decide which of these should be made.

@markcatley markcatley force-pushed the markcatley:version-owner-actions branch 2 times, most recently from 653a122 to 2213b9c Oct 8, 2019
Copy link
Member

carols10cents left a comment

@markcatley I'm sorry we left this PR for so long! Thank you so much for sticking with it. I think we should definitely add some NOT NULL constraints as mentioned, and I would merge either way on renaming the fields in this PR or not.

@markcatley markcatley force-pushed the markcatley:version-owner-actions branch 2 times, most recently from 464cb34 to 73c7238 Nov 3, 2019
@markcatley

This comment has been minimized.

Copy link
Contributor Author

markcatley commented Nov 3, 2019

Hi @carols10cents @sgrif,

I think it's probably a good idea to rename those fields. Never an easier time than when the table is unused (I hope). I believe all the changes have now been made.

Kind regards,
Mark

@markcatley markcatley force-pushed the markcatley:version-owner-actions branch 2 times, most recently from 34b9bf8 to 88d9ec0 Nov 3, 2019
@markcatley markcatley force-pushed the markcatley:version-owner-actions branch from 88d9ec0 to 8d35e31 Nov 3, 2019
Copy link
Member

carols10cents left a comment

This is getting really close! I just noticed a few small things on my latest read through-- please change the underscores in the parameter names and the comments in the tests where noted. Thank you!!

src/models/token.rs Show resolved Hide resolved
src/models/action.rs Outdated Show resolved Hide resolved
src/tests/krate.rs Outdated Show resolved Hide resolved
src/tests/krate.rs Outdated Show resolved Hide resolved
src/tests/krate.rs Outdated Show resolved Hide resolved
src/tests/krate.rs Outdated Show resolved Hide resolved
@carols10cents carols10cents self-assigned this Nov 15, 2019
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 25, 2019

☔️ The latest upstream changes (presumably #1911) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 26, 2019

☔️ The latest upstream changes (presumably #1927) made this pull request unmergeable. Please resolve the merge conflicts.

…ions
The first audit action test covers testing that a crate starts without
any audit actions, and it's unlikely these assertions will ever fail.
@carols10cents

This comment has been minimized.

Copy link
Member

carols10cents commented Dec 2, 2019

I've resolved the merge conflicts and made the small outstanding fixes so that we can merge this in, which I'll do once CI passes :) Thanks!

@carols10cents carols10cents dismissed sgrif’s stale review Dec 2, 2019

all comments have been addressed

@carols10cents

This comment has been minimized.

Copy link
Member

carols10cents commented Dec 2, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 2, 2019

📌 Commit 4d7f8a8 has been approved by carols10cents

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 2, 2019

⌛️ Testing commit 4d7f8a8 with merge f3e0511...

bors added a commit that referenced this pull request Dec 2, 2019
Add audit trail to the publish, yank and unyank transactions.

Contributes to [Issue 1548](#1548)
Based on the commits from [PR 1604](#1604)
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 2, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing f3e0511 to master...

@bors bors merged commit 4d7f8a8 into rust-lang:master Dec 2, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
percy/crates.io Visual review automatically approved, no visual changes found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.