From 4b6685e9a9341b34fa1baa29c305363fdf104ca3 Mon Sep 17 00:00:00 2001
From: Bryan Burgers <bryan@burgers.io>
Date: Mon, 22 Apr 2019 12:25:13 -0500
Subject: [PATCH] Fix broken download graphs

Fix the following assertion error that occurs when running the frontend
in debug mode, which cause graphs to not display at all.

> Assertion Failed: You must include an 'id' for version-download in an
> object passed to 'push'

This has been happening since 3c92ca2b46a6fd166b4ae556b3d925907c85250c
landed.

The fix involves telling Ember how to create a unique ID for a
version-download object, using the composite key.

I haven't been able to confirm, but I believe this is the reason that
graphs in production are only ever counting/displaying a single version.
When using this change locally in debug mode against the live website,
the downloads graphs are rendering correctly.

Fixes #1704.
---
 app/serializers/version-download.js | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 app/serializers/version-download.js

diff --git a/app/serializers/version-download.js b/app/serializers/version-download.js
new file mode 100644
index 00000000000..48c5589a423
--- /dev/null
+++ b/app/serializers/version-download.js
@@ -0,0 +1,7 @@
+import DS from 'ember-data';
+
+export default DS.RESTSerializer.extend({
+    extractId(modelClass, resourceHash) {
+        return `${resourceHash.date}-${resourceHash.version}`;
+    },
+});