Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for showing Travis and Appveyor current build status badges #504
Conversation
carols10cents
referenced this pull request
Jan 16, 2017
Merged
Upload Travis CI and Appveyor badge metadata specified in the manifest #3546
This comment has been minimized.
This comment has been minimized.
|
Looks great to me, thanks @carols10cents! |
alexcrichton
merged commit 0288ef9
into
rust-lang:master
Jan 17, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
carols10cents
deleted the
integer32llc:ci-badge
branch
Jan 17, 2017
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Jan 17, 2017
Arnavion
referenced this pull request
Mar 2, 2017
Closed
Also update `branch` in badges section with the git tag #26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
carols10cents commentedJan 16, 2017
•
edited
This goes with corresponding PR rust-lang/cargo#3546. It probably makes the most sense for this one to go in first.
If a maintainer is testing their project on Travis and Appveyor and so chooses, they can specify attributes for badges for the crate's current build status in its Cargo.toml.
The badges will then get displayed in alphabetical order on both pages that list crates:
and an individual crate's page:
If any badges other than appveyor or travis are specified, crates.io will ignore them and send back a warning for cargo to display. If the "repository" attribute for either badge is missing, crates.io will ignore that badge and warn about it. If any attributes other than the ones crates.io knows about for each badge is specified, those will get ignored and not warned about.